Add NewFile keybinding to Welcome context - #52463
Merged
danilo-leal merged 2 commits intoApr 20, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-codeowner-coordinator
Bot
requested review from
a team,
Anthony-Eid and
danilo-leal
and removed request for
a team
March 26, 2026 02:06
maxdeviant
changed the title
Contributor
Author
Tamo junto Danilaooo!!!! |
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
## Context `ctrl-n` / `cmd-n` doesn't work on the Welcome tab. The global binding lives under `Workspace && !Terminal` (macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there. Closes zed-industries#52426 ## Demo ### Before: https://github.com/user-attachments/assets/69becde8-25d2-45e3-9e7c-416b7937bd17 ### After: https://github.com/user-attachments/assets/6d9ede76-7adb-4527-bfef-c18d5b8a4fb4 ## How to review One line added per platform keymap file. Check that `ctrl-n` / `cmd-n` maps to `workspace::NewFile` in the `Welcome` block of: - `assets/keymaps/default-macos.json` - `assets/keymaps/default-linux.json` - `assets/keymaps/default-windows.json` ## Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed `ctrl-n` / `cmd-n` (New File) not working on the Welcome tab Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Zenor27
pushed a commit
to Zenor27/zed
that referenced
this pull request
Jul 4, 2026
## Context `ctrl-n` / `cmd-n` doesn't work on the Welcome tab. The global binding lives under `Workspace && !Terminal` (macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there. Closes zed-industries#52426 ## Demo ### Before: https://github.com/user-attachments/assets/69becde8-25d2-45e3-9e7c-416b7937bd17 ### After: https://github.com/user-attachments/assets/6d9ede76-7adb-4527-bfef-c18d5b8a4fb4 ## How to review One line added per platform keymap file. Check that `ctrl-n` / `cmd-n` maps to `workspace::NewFile` in the `Welcome` block of: - `assets/keymaps/default-macos.json` - `assets/keymaps/default-linux.json` - `assets/keymaps/default-windows.json` ## Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed `ctrl-n` / `cmd-n` (New File) not working on the Welcome tab Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
## Context `ctrl-n` / `cmd-n` doesn't work on the Welcome tab. The global binding lives under `Workspace && !Terminal` (macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there. Closes zed-industries#52426 ## Demo ### Before: https://github.com/user-attachments/assets/69becde8-25d2-45e3-9e7c-416b7937bd17 ### After: https://github.com/user-attachments/assets/6d9ede76-7adb-4527-bfef-c18d5b8a4fb4 ## How to review One line added per platform keymap file. Check that `ctrl-n` / `cmd-n` maps to `workspace::NewFile` in the `Welcome` block of: - `assets/keymaps/default-macos.json` - `assets/keymaps/default-linux.json` - `assets/keymaps/default-windows.json` ## Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed `ctrl-n` / `cmd-n` (New File) not working on the Welcome tab Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
## Context `ctrl-n` / `cmd-n` doesn't work on the Welcome tab. The global binding lives under `Workspace && !Terminal` (macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there. Closes zed-industries#52426 ## Demo ### Before: https://github.com/user-attachments/assets/69becde8-25d2-45e3-9e7c-416b7937bd17 ### After: https://github.com/user-attachments/assets/6d9ede76-7adb-4527-bfef-c18d5b8a4fb4 ## How to review One line added per platform keymap file. Check that `ctrl-n` / `cmd-n` maps to `workspace::NewFile` in the `Welcome` block of: - `assets/keymaps/default-macos.json` - `assets/keymaps/default-linux.json` - `assets/keymaps/default-windows.json` ## Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed `ctrl-n` / `cmd-n` (New File) not working on the Welcome tab Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ctrl-n/cmd-ndoesn't work on the Welcome tab. The global binding lives underWorkspace && !Terminal(macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there.Closes #52426
Demo
Before:
wecole_before_fix.mp4
After:
welcome_after_fix.mp4
How to review
One line added per platform keymap file. Check that
ctrl-n/cmd-nmaps toworkspace::NewFilein theWelcomeblock of:assets/keymaps/default-macos.jsonassets/keymaps/default-linux.jsonassets/keymaps/default-windows.jsonSelf-review checklist
Release Notes:
ctrl-n/cmd-n(New File) not working on the Welcome tab