Skip to content

git_ui: Disable commit actions during commit message generation - #51727

Merged
cole-miller merged 4 commits into
zed-industries:mainfrom
cppcoffee:git_ui_commit_generation
Jul 18, 2026
Merged

git_ui: Disable commit actions during commit message generation#51727
cole-miller merged 4 commits into
zed-industries:mainfrom
cppcoffee:git_ui_commit_generation

Conversation

@cppcoffee

@cppcoffee cppcoffee commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Release Notes:

  • Add disable commit actions during commit message generation

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 17, 2026
@cppcoffee cppcoffee closed this Mar 17, 2026
@cppcoffee
cppcoffee deleted the git_ui_commit_generation branch March 17, 2026 03:44
@cppcoffee
cppcoffee restored the git_ui_commit_generation branch March 17, 2026 03:44
@cppcoffee cppcoffee reopened this Mar 17, 2026
@cole-miller
cole-miller self-requested a review March 19, 2026 14:25

@cole-miller cole-miller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense, but I don't think we should change the button text to Generating..., it's redundant with the existing UI that shows that a commit message is being generated

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
@cppcoffee
cppcoffee force-pushed the git_ui_commit_generation branch from 78b0d86 to 0c4578c Compare March 24, 2026 01:16
@cppcoffee

Copy link
Copy Markdown
Contributor Author

Thanks! Makes sense, but I don't think we should change the button text to Generating..., it's redundant with the existing UI that shows that a commit message is being generated

Removed the logic for modifying button text and rebased main branch.

@SomeoneToIgnore SomeoneToIgnore added the area:integrations/git Git integration feedback label Apr 28, 2026
@cole-miller
cole-miller enabled auto-merge June 8, 2026 00:35
@cole-miller

Copy link
Copy Markdown
Member

Thanks!

@cole-miller
cole-miller added this pull request to the merge queue Jul 18, 2026
Merged via the queue into zed-industries:main with commit aa09234 Jul 18, 2026
34 checks passed
@cppcoffee
cppcoffee deleted the git_ui_commit_generation branch July 27, 2026 04:50
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…industries#51727)

Release Notes:

- Add disable commit actions during commit message generation

---------

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
playdohface pushed a commit to playdohface/zed that referenced this pull request Aug 29, 2026
…industries#51727)

Release Notes:

- Add disable commit actions during commit message generation

---------

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:integrations/git Git integration feedback cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants