Fix .git/info/exclude patterns matching against wrong root - #51708
Closed
mdippery wants to merge 1 commit into
Closed
Fix .git/info/exclude patterns matching against wrong root#51708mdippery wants to merge 1 commit into
mdippery wants to merge 1 commit into
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @mdippery on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
mdippery
force-pushed
the
bug/git-info-exclude-ignore
branch
2 times, most recently
from
March 17, 2026 00:46
8f40a31 to
3833238
Compare
mdippery
force-pushed
the
bug/git-info-exclude-ignore
branch
from
March 17, 2026 20:41
3833238 to
c63a31b
Compare
Member
|
Thanks! |
cole-miller
enabled auto-merge (squash)
March 19, 2026 14:28
auto-merge was automatically disabled
March 19, 2026 17:47
Head branch was pushed to by a user without write access
mdippery
force-pushed
the
bug/git-info-exclude-ignore
branch
from
March 19, 2026 17:47
c63a31b to
3c3aad3
Compare
Author
|
Fixed formatting issues. |
mdippery
force-pushed
the
bug/git-info-exclude-ignore
branch
from
March 27, 2026 16:30
3c3aad3 to
82ca40a
Compare
Entries in `.git/info/exclude` were not being properly shown as ignored files in the project panel. This was due to the fact that `build_gitignore` was matching against the wrong root when loading entries from `.git/info/exclude`: it was using `.git/info` as the root, but the patterns in that file are relative to the repository root. Entries in `.git/info/exclude` will now be relative to the repository root, and those entries will be shown as ignored in the project panel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mdippery
force-pushed
the
bug/git-info-exclude-ignore
branch
from
April 8, 2026 18:43
82ca40a to
77d76b0
Compare
Member
|
Thanks--without realizing it I merged a different fix PR (#57779) for the same issue; sorry for not following up and letting this become stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries in
.git/info/excludewere not being properly shown as ignored files in the project panel. This was due to the fact thatbuild_gitignorewas matching against the wrong root when loading entries from.git/info/exclude: it was using.git/infoas the root, but the patterns in that file are relative to the repository root. Entries in.git/info/excludewill now be relative to the repository root, and those entries will be shown as ignored in the project panel.Before you mark this PR as ready for review, make sure that you have:
Release Notes:
.git/info/excludewhere not properly marked as ignored in the project panel.