Skip to content

http_client: Fix GitHub downloads failing if the destination path exists - #51548

Merged
Veykril merged 1 commit into
mainfrom
push-vzxuyonzlowm
Mar 14, 2026
Merged

http_client: Fix GitHub downloads failing if the destination path exists#51548
Veykril merged 1 commit into
mainfrom
push-vzxuyonzlowm

Conversation

@Veykril

@Veykril Veykril commented Mar 14, 2026

Copy link
Copy Markdown
Member

cc #45428 (comment)

Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 14, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Mar 14, 2026
@zed-codeowner-coordinator
zed-codeowner-coordinator Bot requested review from a team, kubkon and mikayla-maki and removed request for a team March 14, 2026 11:39
@Veykril

Veykril commented Mar 14, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick preview
/cherry-pick stable

@cppcoffee

Copy link
Copy Markdown
Contributor

It seems we need to either delete or back up the directory first, and then move it over.

@maxdeviant maxdeviant changed the title http_client: Fix github downloads failing if the destination path exists http_client: Fix GitHub downloads failing if the destination path exists Mar 14, 2026
@Veykril
Veykril merged commit e482301 into main Mar 14, 2026
41 checks passed
@Veykril
Veykril deleted the push-vzxuyonzlowm branch March 14, 2026 14:17
github-actions Bot pushed a commit that referenced this pull request Mar 14, 2026
…sts (#51548)

cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
github-actions Bot pushed a commit that referenced this pull request Mar 14, 2026
…sts (#51548)

cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
zed-zippy Bot added a commit that referenced this pull request Mar 14, 2026
…sts (#51548) (cherry-pick to stable) (#51557)

Cherry-pick of #51548 to stable

----
cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy Bot added a commit that referenced this pull request Mar 14, 2026
…sts (#51548) (cherry-pick to preview) (#51556)

Cherry-pick of #51548 to preview

----
cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Co-authored-by: Lukas Wirth <lukas@zed.dev>
tommyming pushed a commit to tommyming/zed that referenced this pull request Mar 15, 2026
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants