Merged
Conversation
cla-bot
bot
added
the
cla-signed
zed-codeowner-coordinator
bot
requested review from
a team,
bennetbo and
kubkon
and removed request for
a team
zed-community-bot
bot
added
the
staff
ConradIrwin
force-pushed
the
desensitized
branch
from
37ebe39 to
155f784
Compare
String panics are unfortunately common at Zed, and doubly unfortunately they may incidentally include the contents of a user's buffer. Although this hasn't happened yet (to my knowledge), I don't want to be in the position of having received sensitive information this way. See also rust-lang/rust#153677
ConradIrwin
force-pushed
the
desensitized
branch
from
155f784 to
3981b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String panics are a non-trivial percentage of the crashes we see at Zed, and
doubly unfortunately they may incidentally include the contents of a user's
buffer.
Although this hasn't happened yet (to my knowledge), I don't want to be
in the position of having received sensitive information this way.
See also rust-lang/rust#153677
Release Notes: