acp: Allow clickable local links in ACP threads - #50398
Closed
danielkrash wants to merge 3 commits into
Closed
Conversation
Added plain filesystem target support in MentionUri::parse for ACP thread links when input is not a URL (:// absent).
|
We require contributors to sign our Contributor License Agreement, and we don't have @danielkrash on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
SomeoneToIgnore
added
the
area:ai
danielkrash
changed the title
Changes: - Remove `split_path_and_line_range` and restructure `parse_plain_file_location` to use `PathWithPosition` as the primary parser. `PathWithPosition` does not support ranges, so line ranges continue to be handled by `parse_line_range`. - Also simplify `looks_like_file_path` by reusing `is_absolute` from the paths util instead of custom path handling.
danielkrash
changed the title
Member
|
Closing in favor or #50443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in codex-acp repository -- Links in Codex response
Before you mark this PR as ready for review, make sure that you have:
Release Notes:
input is not a URL (:// absent)