agent_server_store: Broaden Windows asset detection to all architectures - #50061
Merged
Conversation
Previously only `x86_64` Windows used zip archives, but ARM64 Windows builds also use ZIP format.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Member
|
/cherry-pick preview |
yeskunall
commented
Feb 25, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
…res (#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes #50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
3 tasks
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
…res (#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes #50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
Contributor
|
🍒💥 Cherry-pick did not succeed |
ConradIrwin
pushed a commit
that referenced
this pull request
Feb 25, 2026
…res (#50061) (cherry-pick to preview) (#50062) Cherry-pick of #50061 to preview ---- Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes #50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
3 tasks
pull Bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…res (zed-industries#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes zed-industries#50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
pull Bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…res (zed-industries#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes zed-industries#50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
benbrandt
pushed a commit
that referenced
this pull request
Feb 25, 2026
Following up from #50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Following up from #50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel
3 tasks
zed-zippy Bot
added a commit
that referenced
this pull request
Feb 25, 2026
… (cherry-pick to preview) (#50067) Cherry-pick of #50063 to preview ---- Following up from #50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…res (zed-industries#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes zed-industries#50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…dustries#50063) Following up from zed-industries#50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Following up from zed-industries/zed#50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…res (zed-industries#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes zed-industries#50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…dustries#50063) Following up from zed-industries#50061: when connecting to an ACP adapter fails before any thread is active, errors would not display in the Agent Panel. Falling back to `handle_load_error` to show the error UI properly as it already handles this. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added fallback error handling for connect failures in the Agent Panel
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…res (zed-industries#50061) Previously only `x86_64` Windows used ZIP archives, but ARM64 Windows builds also use ZIP format. Closes zed-industries#50039. > [!NOTE] > The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Broaden Windows asset detection to all architectures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only
x86_64Windows used ZIP archives, but ARM64 Windows builds also use ZIP format.Closes #50039.
Note
The P1 is two-fold: the user cannot download the ZIP file on Windows ARM. BUT -- the Agent Panel is stalled because of that. This ONLY makes it so that the ZIP download doesn’t fail, but if for some reason the download fails, the panel is genuinely stuck with no recovery path. Every restart attempts the same download, hits the same GZIP error, and silently drops it again.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: