Fix panic in inlay hints - #49994
Merged
Merged
Conversation
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev>
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Member
Author
|
/cherry-pick preview |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev>
3 tasks
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev>
Contributor
|
🍒💥 Cherry-pick did not succeed |
zed-zippy Bot
added a commit
that referenced
this pull request
Feb 24, 2026
Cherry-pick of #49994 to preview ---- We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: Cole <cole@zed.dev>
3 tasks
maxdeviant
pushed a commit
that referenced
this pull request
Feb 25, 2026
Fixes ZED-59F This is follow-up work from #49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
pull Bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
pull Bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
We were resolving inlay hints against an old snapshot, which occasionally led to panics Co-Authored-By: Cole <cole@zed.dev> Closes #ISSUE Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed a (rare) panic in inlay hints Co-authored-by: Cole <cole@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…tries#50052) Fixes ZED-59F This is follow-up work from zed-industries#49994; which assumed that can_resolve would return false for an invalid excerpt id. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were resolving inlay hints against an old snapshot, which
occasionally led to panics
Co-Authored-By: Cole cole@zed.dev
Closes #ISSUE
Before you mark this PR as ready for review, make sure that you have:
Release Notes: