Revert "Added support for dismissing the toolchain path selector via … - #49504
Merged
JosephTLyons merged 1 commit intoFeb 18, 2026
Merged
Conversation
…`esc` (zed-industries#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented
|
We require contributors to sign our Contributor License Agreement, and we don't have @polyesterswing on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
JosephTLyons
self-requested a review
February 18, 2026 17:24
Collaborator
|
Nice catch @polyesterswing - reverting for now is probably the best thing to do here. |
Collaborator
|
/cherry-pick preview |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
#49504) …`esc` (#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains.
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
#49504) …`esc` (#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains.
zed-zippy Bot
added a commit
that referenced
this pull request
Feb 18, 2026
#49504) (cherry-pick to stable) (#49529) Cherry-pick of #49504 to stable ---- …`esc` (#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains. Co-authored-by: Kurian Jojo <67583328+polyesterswing@users.noreply.github.com>
zed-zippy Bot
added a commit
that referenced
this pull request
Feb 18, 2026
#49504) (cherry-pick to preview) (#49528) Cherry-pick of #49504 to preview ---- …`esc` (#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains. Co-authored-by: Kurian Jojo <67583328+polyesterswing@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
zed-industries#49504) …`esc` (zed-industries#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
zed-industries#49504) …`esc` (zed-industries#48201)" This reverts commit ef20be3. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
esc(#48201)"This reverts commit 174fc51.
Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains
confirmfunction toocc: @JosephTLyons
Release Notes: