chore: remove no-longer needed search_on_input=false toggle before tests - #49161
Merged
SomeoneToIgnore merged 1 commit intoFeb 14, 2026
Merged
chore: remove no-longer needed search_on_input=false toggle before tests#49161SomeoneToIgnore merged 1 commit into
SomeoneToIgnore merged 1 commit into
Conversation
cla-bot
Bot
added
the
cla-signed
SomeoneToIgnore
approved these changes
Feb 14, 2026
SomeoneToIgnore
enabled auto-merge (squash)
February 14, 2026 08:12
Contributor
Have feedback on this plugin? Let's hear it! |
rtfeldman
pushed a commit
that referenced
this pull request
Feb 17, 2026
…sts (#49161) Just cleaning up after myself. When search_on_input was toggled default [in this PR](1f831e0) I toggled it to false before a few tests that weren't expecting it. Then [this PR changed](#49150) it to be false by default and the extra toggle before the tests slipped through. Think it's a good idea to remove this to avoid any confusion in the future. @SomeoneToIgnore Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…sts (zed-industries#49161) Just cleaning up after myself. When search_on_input was toggled default [in this PR](zed-industries@1f831e0) I toggled it to false before a few tests that weren't expecting it. Then [this PR changed](zed-industries#49150) it to be false by default and the extra toggle before the tests slipped through. Think it's a good idea to remove this to avoid any confusion in the future. @SomeoneToIgnore Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…sts (zed-industries#49161) Just cleaning up after myself. When search_on_input was toggled default [in this PR](zed-industries@1f831e0) I toggled it to false before a few tests that weren't expecting it. Then [this PR changed](zed-industries#49150) it to be false by default and the extra toggle before the tests slipped through. Think it's a good idea to remove this to avoid any confusion in the future. @SomeoneToIgnore Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just cleaning up after myself.
When search_on_input was toggled default in this PR I toggled it to false before a few tests that weren't expecting it.
Then this PR changed it to be false by default and the extra toggle before the tests slipped through.
Think it's a good idea to remove this to avoid any confusion in the future.
@SomeoneToIgnore
Release Notes: