Fix exotic fold range kinds by SomeoneToIgnore · Pull Request #49151 · zed-industries/zed

SomeoneToIgnore · 2026-02-13T23:41:04Z

Follow-up of #48611

Despite Zed not declaring such support in its capabilities,

Lines 1010 to 1016 in a0eb63d

    
           folding_range_kind: Some(FoldingRangeKindCapability { 
        
               value_set: Some(vec![ 
        
                   FoldingRangeKind::Comment, 
        
                   FoldingRangeKind::Region, 
        
                   FoldingRangeKind::Imports, 
        
               ]), 
        
           }),

json-language-server returns object as a folding range kind:

The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind

but mentions that the real type

The type is a string since the value set is extensible

The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization.

See also: zed-industries/lsp-types#10

Release Notes:

Fixed json-language-server document folds not being parsed correctly

<img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10

SomeoneToIgnore · 2026-02-13T23:52:50Z

/cherry-pick preview

Follow-up of #48611 Despite Zed not declaring such support in its capabilities, https://github.com/zed-industries/zed/blob/a0eb63d1affb6e7b7991e477c7e05824d0250255/crates/lsp/src/lsp.rs#L1010-L1016 `json-language-server` returns `object` as a folding range kind: <img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10 Release Notes: - Fixed `json-language-server` document folds not being parsed correctly

Cherry-pick of #49151 to preview ---- Follow-up of #48611 Despite Zed not declaring such support in its capabilities, https://github.com/zed-industries/zed/blob/a0eb63d1affb6e7b7991e477c7e05824d0250255/crates/lsp/src/lsp.rs#L1010-L1016 `json-language-server` returns `object` as a folding range kind: <img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10 Release Notes: - Fixed `json-language-server` document folds not being parsed correctly Co-authored-by: Kirill Bulatov <kirill@zed.dev>

Follow-up of #48611 Despite Zed not declaring such support in its capabilities, https://github.com/zed-industries/zed/blob/a0eb63d1affb6e7b7991e477c7e05824d0250255/crates/lsp/src/lsp.rs#L1010-L1016 `json-language-server` returns `object` as a folding range kind: <img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10 Release Notes: - Fixed `json-language-server` document folds not being parsed correctly

Follow-up of zed-industries#48611 Despite Zed not declaring such support in its capabilities, https://github.com/zed-industries/zed/blob/a0eb63d1affb6e7b7991e477c7e05824d0250255/crates/lsp/src/lsp.rs#L1010-L1016 `json-language-server` returns `object` as a folding range kind: <img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10 Release Notes: - Fixed `json-language-server` document folds not being parsed correctly

Follow-up of zed-industries#48611 Despite Zed not declaring such support in its capabilities, https://github.com/zed-industries/zed/blob/219b612f63da6698b321e3b741d46954b566eb37/crates/lsp/src/lsp.rs#L1010-L1016 `json-language-server` returns `object` as a folding range kind: <img width="1728" height="720" alt="bad" src="https://github.com/user-attachments/assets/ee574879-8657-41c8-ab12-562f3882f057" /> The spec, even 3.18, does not really seem to allow it explicitly: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#foldingRangeKind but mentions that the real type > The type is a string since the value set is extensible The PR adds a capture enum variant for such cases, to get the folds in instead of failing on deserialization. See also: zed-industries/lsp-types#10 Release Notes: - Fixed `json-language-server` document folds not being parsed correctly

cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Feb 13, 2026

zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Feb 13, 2026

SomeoneToIgnore enabled auto-merge (squash) February 13, 2026 23:42

SomeoneToIgnore merged commit 21bc4f1 into main Feb 13, 2026
38 checks passed

SomeoneToIgnore deleted the kb/lenient-fold-types branch February 13, 2026 23:51

zed-zippy Bot mentioned this pull request Feb 13, 2026

Fix exotic fold range kinds (#49151) (cherry-pick to preview) #49152

Merged

Navigation Menu

Uh oh!

Uh oh!

Fix exotic fold range kinds - #49151

Fix exotic fold range kinds#49151
SomeoneToIgnore merged 1 commit into
mainfrom
kb/lenient-fold-types

SomeoneToIgnore commented Feb 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

SomeoneToIgnore commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	folding_range_kind: Some(FoldingRangeKindCapability {
	value_set: Some(vec![
	FoldingRangeKind::Comment,
	FoldingRangeKind::Region,
	FoldingRangeKind::Imports,
	]),
	}),

Uh oh!

Uh oh!

Conversation

SomeoneToIgnore commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

SomeoneToIgnore commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

SomeoneToIgnore commented Feb 13, 2026 •

edited

Loading