Make Workspace::test_new pub(crate), use MultiWorkspace::test_new everywhere - #48813
Merged
Merged
Conversation
…rywhere External crates now use MultiWorkspace::test_new instead of Workspace::test_new, which reflects the actual runtime reality where MultiWorkspace is the window root. Added MultiWorkspace::test_add_workspace helper for tests that need to create additional workspaces within a MultiWorkspace.
rtfeldman
marked this pull request as ready for review
February 9, 2026 21:32
mikayla-maki
pushed a commit
that referenced
this pull request
Feb 10, 2026
…rywhere (#48813) Makes `Workspace::test_new` `pub(crate)` so it can only be called from within the workspace crate. All external test code now uses `MultiWorkspace::test_new` instead, which reflects the actual runtime reality where `MultiWorkspace` is the window root. ### Changes - `Workspace::test_new` visibility changed from `pub` to `pub(crate)` - Added `MultiWorkspace::test_add_workspace` helper for tests that need additional workspaces - Migrated ~285 call sites across 33 external files to use `MultiWorkspace::test_new` - Updated helper functions that took `&WindowHandle<Workspace>` to take `&Entity<Workspace>` Release Notes: - N/A
mikayla-maki
pushed a commit
that referenced
this pull request
Feb 10, 2026
…rywhere (#48813) Makes `Workspace::test_new` `pub(crate)` so it can only be called from within the workspace crate. All external test code now uses `MultiWorkspace::test_new` instead, which reflects the actual runtime reality where `MultiWorkspace` is the window root. - `Workspace::test_new` visibility changed from `pub` to `pub(crate)` - Added `MultiWorkspace::test_add_workspace` helper for tests that need additional workspaces - Migrated ~285 call sites across 33 external files to use `MultiWorkspace::test_new` - Updated helper functions that took `&WindowHandle<Workspace>` to take `&Entity<Workspace>` Release Notes: - N/A
mikayla-maki
pushed a commit
that referenced
this pull request
Feb 11, 2026
…rywhere (#48813) Makes `Workspace::test_new` `pub(crate)` so it can only be called from within the workspace crate. All external test code now uses `MultiWorkspace::test_new` instead, which reflects the actual runtime reality where `MultiWorkspace` is the window root. - `Workspace::test_new` visibility changed from `pub` to `pub(crate)` - Added `MultiWorkspace::test_add_workspace` helper for tests that need additional workspaces - Migrated ~285 call sites across 33 external files to use `MultiWorkspace::test_new` - Updated helper functions that took `&WindowHandle<Workspace>` to take `&Entity<Workspace>` Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
Workspace::test_newpub(crate)so it can only be called from within the workspace crate. All external test code now usesMultiWorkspace::test_newinstead, which reflects the actual runtime reality whereMultiWorkspaceis the window root.Changes
Workspace::test_newvisibility changed frompubtopub(crate)MultiWorkspace::test_add_workspacehelper for tests that need additional workspacesMultiWorkspace::test_new&WindowHandle<Workspace>to take&Entity<Workspace>Release Notes: