Fix settings migrations for nested platform/channel/profile keys - #48550

Merged

rtfeldman merged 19 commits into

mainfrom

pr/fix-nested-settings-migrations

Feb 6, 2026

Commits on Feb 6, 2026

Fix existing settings migrations for nested platform/channel/profile keys
rtfeldman
committed
80f4bcc
Revert edit_predictions bail on non-object back to origin/main
rtfeldman
committed
af4f251
Make release_channel::gpui optional, use strum to enumerate platform/channel override keys in migrations
rtfeldman
committed
2196c64
Remove unused strum::IntoStaticStr derive from ReleaseChannel
rtfeldman
committed
87cdb11
Add tests for settings migrations with root + platform + profile combined
rtfeldman
committed
fe03edb
Clarify SupportedPlatform::as_str() doc comment
rtfeldman
committed
b05d3b7
Restore .log_err() calls in visual_test_runner.rs
rtfeldman
committed
3dec582
Extract migrate_nested_settings helper to deduplicate traversal boilerplate
rtfeldman
committed
008237b
Use migrate_nested_settings in file_finder and relative_line_numbers migrations
rtfeldman
committed
b82efd9
Add missing newline at eof
rtfeldman
committed
13c54d0
Merge remote-tracking branch 'origin/main' into pr/fix-nested-settings-migrations
rtfeldman
committed
ca725b7
Inline override keys instead of depending on release_channel
rtfeldman
committed
3080180
Use release_channel enums for settings override keys instead of hardcoded strings
rtfeldman
committed
6d96c8f
Fix missing trailing whitespace
rtfeldman
committed
8543567
Update formatter migrations to handle platform/profile/language nesting
rtfeldman
committed
d11abee
Use settings_content structs as single source of truth for override keys
rtfeldman
committed
5faa052
Derive override keys from struct fields via macro_rules
rtfeldman
committed
a2d2644
Rename migrate_nested_settings -> migrate_settings, migrate_nested_language_setting -> migrate_language_setting
rtfeldman
committed
9431813
Match original nested if-let style in remove_context_server_source
rtfeldman
committed
7f612d8

Navigation Menu

Uh oh!

Fix settings migrations for nested platform/channel/profile keys - #48550

Fix settings migrations for nested platform/channel/profile keys#48550
rtfeldman merged 19 commits into
mainfrom
pr/fix-nested-settings-migrations

Commits on Feb 6, 2026

Fix existing settings migrations for nested platform/channel/profile keys

Revert edit_predictions bail on non-object back to origin/main

Make release_channel::gpui optional, use strum to enumerate platform/channel override keys in migrations

Remove unused strum::IntoStaticStr derive from ReleaseChannel

Add tests for settings migrations with root + platform + profile combined

Clarify SupportedPlatform::as_str() doc comment

Restore .log_err() calls in visual_test_runner.rs

Extract migrate_nested_settings helper to deduplicate traversal boilerplate

Use migrate_nested_settings in file_finder and relative_line_numbers migrations

Add missing newline at eof

Merge remote-tracking branch 'origin/main' into pr/fix-nested-settings-migrations

Inline override keys instead of depending on release_channel

Use release_channel enums for settings override keys instead of hardcoded strings

Fix missing trailing whitespace

Update formatter migrations to handle platform/profile/language nesting

Use settings_content structs as single source of truth for override keys

Derive override keys from struct fields via macro_rules

Rename migrate_nested_settings -> migrate_settings, migrate_nested_language_setting -> migrate_language_setting

Match original nested if-let style in remove_context_server_source