Skip to content

editor: Use tabs bitmask when syncing #48366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veykril merged 1 commit into from
Feb 4, 2026
Merged

editor: Use tabs bitmask when syncing #48366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/editor/src/display_map/tab_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ impl TabMap {
false,
Highlights::default(),
) {
// todo(performance use tabs bitmask)
for (ix, _) in chunk.text.match_indices('\t') {
let offset_from_edit = offset_from_edit + (ix as u32);
let mut remaining_tabs = chunk.tabs;
while remaining_tabs != 0 {
let ix = remaining_tabs.trailing_zeros();
let offset_from_edit = offset_from_edit + ix;
if first_tab_offset.is_none() {
first_tab_offset = Some(offset_from_edit);
}
Expand All @@ -93,6 +94,8 @@ impl TabMap {
} else if !was_expanded && !is_expanded {
break 'outer;
}

remaining_tabs &= remaining_tabs - 1;
}

offset_from_edit += chunk.text.len() as u32;
Expand Down