agent_ui: Fix panic when inserting context prefix with multi-byte characters (#48179) (cherry-pick to preview) - #48180
Merged
Conversation
…racters (#48179) Closes ZED-4R9 Introduced in #47768 The `insert_context_prefix` function was using byte offsets to check if the prefix already exists at the cursor. This caused a panic with multi-byte characters like emojis. Now uses character counts instead. Release Notes: - Fixed a crash in the Agent Panel when inserting context mentions with emojis in the message editor.
cla-bot
Bot
added
the
cla-signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #48179 to preview
Closes ZED-4R9
Introduced in #47768
The
insert_context_prefixfunction was using byte offsets to check ifthe prefix already exists at the cursor. This caused a panic with
multi-byte characters like emojis. Now uses character counts instead.
Release Notes:
emojis in the message editor.