Markdown link renderer and Thread View Mention links - #48074
Closed
pkondzior wants to merge 4 commits into
Closed
Conversation
pkondzior
marked this pull request as ready for review
January 31, 2026 08:46
pkondzior
force-pushed
the
markdown-link-renderer
branch
from
February 2, 2026 10:55
2c3c7f4 to
bf43521
Compare
Member
|
Thanks for this, but given the state of things and this PR's dependencies, going to close for now |
|
This is a very useful feature. Looking forward to seeing it implemented soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds native-looking Mentions in the Agent Panel Thread view by introducing a custom inline Markdown link renderer.
Dependency
zed-industries/zedDemo:
Mentions.Demo.1.mp4
Also included
MentionCreasechanges into this MVP PR.MentionCreasechanges are independent: they do not depend on the Markdown link renderer or the gpui inline layout work.List of changes:
LinkRendererandLinkRenderContext, allowing callers to render links as arbitrary elements instead of plain inline text.LinkLabelto preserve mixed inline content (text + child elements) inside links, so custom renderers can reproduce the full link label.PendingInline/PendingItemand alink_stack, then render links at close time viapop_link.MarkdownElement::link_renderer(...)now lets the Agent thread view provide a custom renderer; mention links are rendered asMentionCreasewith active/selected styling.AcpThreadView::link_renderer(...)parses links intoMentionUriand renders mentions as clickable buttons; non‑mention links fall back to the default link element.Related #37563
Release Notes: