terminal: Fix double quoting of commands on Windows cmd.exe

[lingyaochu]

Closes #47303

The command quoting for cmd shell was first introduced (at least in this case) in PR #41216 three months ago:

zed/crates/project/src/terminals.rs

Lines 202 to 210 in 3d4582d

	let mut arg =
	format!("{activation_script}{separator} {to_run}");
	if shell_kind == ShellKind::Cmd {
	// We need to put the entire command in quotes since otherwise CMD tries to execute them
	// as separate commands rather than chaining one after another.
	arg = format!("\"{arg}\"");
	}
	let args = shell_kind.args_for_shell(false, arg);

And a month ago, PR #42382 added command quoting for cmd in a different place:

zed/crates/util/src/shell.rs

Lines 413 to 434 in 3d4582d

	pub fn args_for_shell(&self, interactive: bool, combined_command: String) -> Vec<String> {
	match self {
	ShellKind::PowerShell | ShellKind::Pwsh => vec!["-C".to_owned(), combined_command],
	ShellKind::Cmd => vec![
	"/S".to_owned(),
	"/C".to_owned(),
	format!("\"{combined_command}\""),
	],
	ShellKind::Posix
	| ShellKind::Nushell
	| ShellKind::Fish
	| ShellKind::Csh
	| ShellKind::Tcsh
	| ShellKind::Rc
	| ShellKind::Xonsh
	| ShellKind::Elvish => interactive
	.then(|| "-i".to_owned())
	.into_iter()
	.chain(["-c".to_owned(), combined_command])
	.collect(),
	}
	}

As a result, the command is now quoted twice when using cmd. cmd interprets the entire double-quoted string (e.g., ""command & args"") as a single (invalid) executable name, and this would lead to an error like “The system cannot find the path specified” in #47303 .

The solution is to remove the redundant manual quoting in terminals.rs and rely on the centralized logic in util/src/shell.rs.

/cc @Veykril @reflectronic

Release Notes:

• Fixed a bug where terminal tasks failed to start on Windows when using cmd.exe.

[Veykril]

Thanks!

[Veykril]

/cherry-pick preview