acp: Add XDouble icon for reject_always permission #46329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACP permission UI shows a double checkmark for Allow Always but only a single X for Reject Always. This adds an XDouble icon matching the CheckDouble pattern to fix this visual inconsistency. Release Notes: - N/A
cla-bot
bot
added
the
cla-signed
4 tasks
SomeoneToIgnore
added
the
area:ai
Member
|
Heya, thanks for the PR! I totally get why you're adding it as it makes it consistent with the allow all icon, but I think I'll tweak this UI somewhat soon and will explore not having icons at all. That said, I'll close this one for now; but thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses double X (✗✗) for "Reject Always" permission button, matching how "Allow Always" uses double checkmark (✓✓)
Test plan
Before:
After:
