ep: Fix code block extraction to require closing fence at line start - #46270
Merged
Conversation
`extract_last_codeblock` was using `find()` to locate closing fences, which would match backticks anywhere in the text. This caused incorrect parsing when the content contained inline backticks or nested code blocks, resulting in wrong diffs. Fix by requiring the closing fence to be preceded by a newline.
cla-bot
Bot
added
the
cla-signed
osyvokon
enabled auto-merge (squash)
January 7, 2026 16:41
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
…46270) `extract_last_codeblock` was using `find()` to locate closing fences, which would match backticks anywhere in the text. This caused incorrect parsing when the content contained inline backticks or nested code blocks, resulting in wrong diffs. Fix by requiring the closing fence to be preceded by a newline. Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ed-industries#46270) `extract_last_codeblock` was using `find()` to locate closing fences, which would match backticks anywhere in the text. This caused incorrect parsing when the content contained inline backticks or nested code blocks, resulting in wrong diffs. Fix by requiring the closing fence to be preceded by a newline. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ed-industries#46270) `extract_last_codeblock` was using `find()` to locate closing fences, which would match backticks anywhere in the text. This caused incorrect parsing when the content contained inline backticks or nested code blocks, resulting in wrong diffs. Fix by requiring the closing fence to be preceded by a newline. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_last_codeblockwas usingfind()to locate closing fences,which would match backticks anywhere in the text. This caused incorrect
parsing when the content contained inline backticks or nested code
blocks, resulting in wrong diffs.
Fix by requiring the closing fence to be preceded by a newline.
Release Notes: