Update pulldown-cmark to v0.13.0 to fix crash - #46267
Merged
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @drbh on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @drbh on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
drbh
changed the title
drbh
changed the title
MrSubidubi
changed the title
Contributor
Author
|
whoops apologies for the pr renaming I didn't see that you updated it @MrSubidubi! Thanks for the quick look |
MrSubidubi
approved these changes
Jan 8, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Nice, thank you very much for looking into this and the detailed context! Much appreciated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Member
|
/cherry-pick preview |
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
```md
- [ ] -
\
-
```
*easier to read escape characters below
```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```
## how to reproduce
1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash
I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.
## recording
https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb
Release Notes:
- Fixes crash due to markdown parsing via bumping pulldown-cmark
Member
|
/cherry-pick stable |
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
```md
- [ ] -
\
-
```
*easier to read escape characters below
```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```
## how to reproduce
1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash
I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.
## recording
https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb
Release Notes:
- Fixes crash due to markdown parsing via bumping pulldown-cmark
zed-zippy Bot
added a commit
that referenced
this pull request
Jan 8, 2026
…o stable) (#46310) Cherry-pick of #46267 to stable ---- Hi Zed team thank you for the awesome editor! I recently stumbled upon a markdown sequence that seems to cause a crash ```md - [ ] - \ - ``` *easier to read escape characters below ```rust let crash_input = "-\t[\t] -\r\\\n-" println!("{}", crash_input) ``` ## how to reproduce 1. copy the markdown above 2. save the file 3. `[shift]` + `[cmd]` + `p` to open the command palette 4. select `markdown: open preview` 5. crash I've confirmed that the issue is a bug in pulldown-cmark version 12, and has been resolved in version [v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0) and specifically fixed in pulldown-cmark/pulldown-cmark#1017 this PR simply bumps the pulldown-cmark version in zed which resolves the crash on my local machine. ## recording https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb Release Notes: - Fixes crash due to markdown parsing via bumping pulldown-cmark Co-authored-by: drbh <david.richard.holtz@gmail.com>
zed-zippy Bot
added a commit
that referenced
this pull request
Jan 8, 2026
…o preview) (#46309) Cherry-pick of #46267 to preview ---- Hi Zed team thank you for the awesome editor! I recently stumbled upon a markdown sequence that seems to cause a crash ```md - [ ] - \ - ``` *easier to read escape characters below ```rust let crash_input = "-\t[\t] -\r\\\n-" println!("{}", crash_input) ``` ## how to reproduce 1. copy the markdown above 2. save the file 3. `[shift]` + `[cmd]` + `p` to open the command palette 4. select `markdown: open preview` 5. crash I've confirmed that the issue is a bug in pulldown-cmark version 12, and has been resolved in version [v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0) and specifically fixed in pulldown-cmark/pulldown-cmark#1017 this PR simply bumps the pulldown-cmark version in zed which resolves the crash on my local machine. ## recording https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb Release Notes: - Fixes crash due to markdown parsing via bumping pulldown-cmark Co-authored-by: drbh <david.richard.holtz@gmail.com>
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
```md
- [ ] -
\
-
```
*easier to read escape characters below
```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```
## how to reproduce
1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash
I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.
## recording
https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb
Release Notes:
- Fixes crash due to markdown parsing via bumping pulldown-cmark
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
```md
- [ ] -
\
-
```
*easier to read escape characters below
```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```
## how to reproduce
1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash
I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.
## recording
https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb
Release Notes:
- Fixes crash due to markdown parsing via bumping pulldown-cmark
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
```md
- [ ] -
\
-
```
*easier to read escape characters below
```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```
## how to reproduce
1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash
I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.
## recording
https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb
Release Notes:
- Fixes crash due to markdown parsing via bumping pulldown-cmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Zed team thank you for the awesome editor!
I recently stumbled upon a markdown sequence that seems to cause a crash
*easier to read escape characters below
how to reproduce
[shift]+[cmd]+pto open the command palettemarkdown: open previewI've confirmed that the issue is a bug in pulldown-cmark version 12, and has been resolved in version v0.13.0 and specifically fixed in pulldown-cmark/pulldown-cmark#1017
this PR simply bumps the pulldown-cmark version in zed which resolves the crash on my local machine.
recording
zedcrash.mp4
Release Notes: