Improve visual test runner: consolidate setup, add constants, remove dead code - #46217
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
…dead code - Add PIXEL_TOLERANCE constant (extracted from pixels_are_similar) - Add workspace_window_size() and agent_panel_window_size() helper functions - Create TestWorkspace struct to encapsulate workspace creation - Create setup_project_panel() and open_file() helper functions - Replace counter-based test result tracking with simpler any_failed boolean - Remove unused let _ = update_baseline and let _ = (passed, updated) lines - Extract test file content into constants (MAIN_RS_CONTENT, etc.) - Standardize timer durations for more consistency Note: FakeFs could not be used because it requires TestDispatcher which is not available in Application::new().run() context.
rtfeldman
changed the title
rtfeldman
marked this pull request as ready for review
January 7, 2026 03:57
rtfeldman
added
the
area:ai
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…dead code (zed-industries#46217) Just some code cleanup to improve the tests - make them better exemplars for future use. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…dead code (zed-industries#46217) Just some code cleanup to improve the tests - make them better exemplars for future use. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some code cleanup to improve the tests - make them better exemplars for future use.
Release Notes: