gpui: Cancel foreground tasks when the app is dropped - #45768
Merged
Conversation
…S-first approach - Remove AppContext::Result associated type entirely (all contexts return T directly) - Remove Flatten trait (no longer needed without Result<Result<T>>) - Restructure phases: macOS first, then other platforms, then API changes - Split codebase migration (phases 3-5) to separate brief - Add async-app-result-removal-migration.md for future ~500+ callsite updates
cla-bot
Bot
added
the
cla-signed
allowing this to be dropped from any thread.
mikayla-maki
changed the title
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
This is in preparation for removing `Result<T>` from the `AsyncApp` methods Refactor machine goes brrrrrr Plan and tracker for this PR: https://gist.github.com/mikayla-maki/7dfc0d4907e76de119b5712e24665f02 This PR should be safe to merge, as I cannot observe any changes in behavior from adding this to our application. Release Notes: - N/A
mikayla-maki
added a commit
that referenced
this pull request
Jan 7, 2026
Depends on: #45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
rtfeldman
pushed a commit
that referenced
this pull request
Jan 8, 2026
Depends on: #45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
rtfeldman
pushed a commit
that referenced
this pull request
Jan 9, 2026
Depends on: #45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
samuel-jimenez
pushed a commit
to samuel-jimenez/GramEditor
that referenced
this pull request
Apr 2, 2026
Depends on: zed-industries/zed#45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Depends on: zed-industries/zed#45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…#45768) This is in preparation for removing `Result<T>` from the `AsyncApp` methods Refactor machine goes brrrrrr Plan and tracker for this PR: https://gist.github.com/mikayla-maki/7dfc0d4907e76de119b5712e24665f02 This PR should be safe to merge, as I cannot observe any changes in behavior from adding this to our application. Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Depends on: zed-industries#45768 Refactor plan: https://gist.github.com/mikayla-maki/6c4bf263fd80050715ba01f45478796e Overall plan: https://gist.github.com/mikayla-maki/7bb5078e4385a2e683e1e1eb40d17d38 This is the big one. Release Notes: - N/A --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#45768) This is in preparation for removing `Result<T>` from the `AsyncApp` methods Refactor machine goes brrrrrr Plan and tracker for this PR: https://gist.github.com/mikayla-maki/7dfc0d4907e76de119b5712e24665f02 This PR should be safe to merge, as I cannot observe any changes in behavior from adding this to our application. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for removing
Result<T>from theAsyncAppmethodsRefactor machine goes brrrrrr
Plan and tracker for this PR: https://gist.github.com/mikayla-maki/7dfc0d4907e76de119b5712e24665f02
This PR should be safe to merge, as I cannot observe any changes in behavior from adding this to our application.
Release Notes: