Skip to content

repl: Add SVG support to the REPL - #44512

Closed
auriium2 wants to merge 5 commits into
zed-industries:mainfrom
auriium2:svg-support
Closed

repl: Add SVG support to the REPL#44512
auriium2 wants to merge 5 commits into
zed-industries:mainfrom
auriium2:svg-support

Conversation

@auriium2

@auriium2 auriium2 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

To move towards latex support and eventual full jupyter notebook support, this PR adds basic svg mimetype support using the svg renderer.

Changes:

  • Added a temporary cargo patch to jupyter_protocol (see this for why, tldr: jupyter_protocol crate was seeing image/svg mimetype as image first, but handler for image/ prefix specifically did not handle svg mimetype and so all image/svg mimetypes would be parsed as an 'other')
  • added a SVGView similar to the ImageView foundation, which uses the svg_renderer to render svgs
  • Added output type and mimetype arm in outputs.rs to handle the svg mimetype (not possible without patch since svg would be parsed as an other)

Partially addresses:

Caveats:

Before:
image

After:
image

Release Notes:

  • Added basic svg support to the repl

@cla-bot

cla-bot Bot commented Dec 10, 2025

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @auriium2 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-industries-bot

zed-industries-bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor
Messages
📖

This PR includes links to the following GitHub Issues: #runtimed/runtimed#199
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 37c0fe7

@auriium2

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Dec 10, 2025
@cla-bot

cla-bot Bot commented Dec 10, 2025

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@auriium2 auriium2 changed the title repl: add basic svg support repl: Add svg support to the REPL Dec 10, 2025
@maxdeviant maxdeviant changed the title repl: Add svg support to the REPL repl: Add SVG support to the REPL Dec 10, 2025
@rgbkrk

rgbkrk commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

Dope.

@auriium2

Copy link
Copy Markdown
Contributor Author

Ready to go!

@rgbkrk rgbkrk added the area:repl repl, jupyter, notebooks, etc label Jan 7, 2026
@rgbkrk

rgbkrk commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Please rebase this when you get a chance.

@rgbkrk

rgbkrk commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Since we merged and shipped your work in the jupyter crates we should just bump the version of the jupyter packages here so you don't have to work around it.

@rgbkrk

rgbkrk commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

I brought in the latest package and can take over this PR with credit to you @auriium2

@auriium2

Copy link
Copy Markdown
Contributor Author

@rgbkrk Sounds good to me, been buried in research/school/other crap but i'll eventually be back with some more latex related stuff as well. Thanks for the help!

@ChristopherBiscardi

Copy link
Copy Markdown
Contributor

Since the PR needs some updates, the original author doesn't have time, and someone offered to take over I'm going to close this PR even though it seems the functionality is still desired. A new updated PR is welcome.

@rgbkrk

rgbkrk commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

@ChristopherBiscardi thank you! Sorry I said I'd take over but I think I'll be stepping away from Zed contributions for a bit. If people want me to come back to this for sure, ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:repl repl, jupyter, notebooks, etc cla-signed The user has signed the Contributor License Agreement

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

7 participants