agent_ui: Add button to delete all threads - #44244
Closed
linuxsoares wants to merge 1 commit into
Closed
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @linuxsoares on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Member
|
Hey, thanks for working on this! Curious how is this different from #43370? |
Member
|
I'll close this PR in the meantime; we already support this feature as per the linked PR above. Ping me if I'm missing anything here. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Remove All History" feature to the agent UI, allowing users to delete all history threads at once. The most important changes are grouped below:
Feature Implementation:
RemoveHistoryaction and handler toAcpThreadView, enabling the deletion of all history threads viahistory_store.delete_threads(cx)[1] [2].RemoveHistoryaction when clicked [1] [2].Action Handling and Integration:
remove_all_historyaction handler in the main action dispatch forAcpThreadViewto ensure the action is processed correctly.project.clone()instead ofproject.downgrade()for consistency [1] [2].Testing:
thread_view.rsandthread_history.rs, covering scenarios such as empty history, existing threads, button click, session preservation, and confirmation state resets [1] [2].These changes collectively provide a robust and user-friendly way to clear all history threads from the agent UI, with thorough validation to ensure reliability.