Skip to content

Make key repeat rate on Wayland more precise (2) #43589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yara-blue merged 2 commits into from
Nov 26, 2025
Merged

Make key repeat rate on Wayland more precise (2) #43589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46004b
fix keyrepeat rate by measuring processing time
olejorgenb Jul 23, 2025
0095bc1
Revise approach
olejorgenb Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/gpui/src/platform/linux/wayland/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,6 +1389,7 @@ impl Dispatch<wl_keyboard::WlKeyboard, ()> for WaylandClientStatePtr {
state.repeat.current_keycode = Some(keycode);

let rate = state.repeat.characters_per_second;
let repeat_interval = Duration::from_secs(1) / rate;

@rubbieKelvin rubbieKelvin Dec 12, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let repeat_interval = Duration::from_secs(1) / rate;
let repeat_interval = Duration::from_secs(1) / rate.max(1);

to prevent division by zero crash?

@olejorgenb olejorgenb Dec 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did not consider 0 was a possible rate, but I guess it's possible to configure that if you want to turn of key-repeat altogether. Fixed here: #44151

let id = state.repeat.current_id;
state
.loop_handle
Expand All @@ -1398,7 +1399,7 @@ impl Dispatch<wl_keyboard::WlKeyboard, ()> for WaylandClientStatePtr {
is_held: true,
prefer_character_input: false,
});
move |_event, _metadata, this| {
move |event_timestamp, _metadata, this| {
let mut client = this.get_client();
let mut state = client.borrow_mut();
let is_repeating = id == state.repeat.current_id
Expand All @@ -1415,7 +1416,8 @@ impl Dispatch<wl_keyboard::WlKeyboard, ()> for WaylandClientStatePtr {
drop(state);
focused_window.handle_input(input.clone());

TimeoutAction::ToDuration(Duration::from_secs(1) / rate)
// If the new scheduled time is in the past the event will repeat as soon as possible
TimeoutAction::ToInstant(event_timestamp + repeat_interval)
}
})
.unwrap();
Expand Down
Loading