Skip to content

Implement vertical scrolling for extended keymap load error information #42542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrSubidubi merged 4 commits into from
Nov 26, 2025
Merged

Implement vertical scrolling for extended keymap load error information #42542

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ab0794
Enable y-axis scroll to view extended keymap load error information
ihavecoke Nov 12, 2025
e172389
.
ihavecoke Nov 24, 2025
b63afcd
.
ihavecoke Nov 25, 2025
d6a7ccd
.
ihavecoke Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions crates/workspace/src/notifications.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,9 +593,9 @@ pub mod simple_message_notification {

use gpui::{
AnyElement, DismissEvent, EventEmitter, FocusHandle, Focusable, ParentElement, Render,
SharedString, Styled,
ScrollHandle, SharedString, Styled,
};
use ui::prelude::*;
use ui::{WithScrollbar, prelude::*};

use crate::notifications::NotificationFrame;

Expand All @@ -617,6 +617,7 @@ pub mod simple_message_notification {
show_close_button: bool,
show_suppress_button: bool,
title: Option<SharedString>,
scroll_handle: ScrollHandle,
}

impl Focusable for MessageNotification {
Expand Down Expand Up @@ -661,6 +662,7 @@ pub mod simple_message_notification {
show_suppress_button: true,
title: None,
focus_handle: cx.focus_handle(),
scroll_handle: ScrollHandle::new(),
}
}

Expand Down Expand Up @@ -777,7 +779,18 @@ pub mod simple_message_notification {
fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
NotificationFrame::new()
.with_title(self.title.clone())
.with_content((self.build_content)(window, cx))
.with_content(
div()
.child(
div()
.id("message-notification-content")
.max_h(vh(0.6, window))
.overflow_y_scroll()
.track_scroll(&self.scroll_handle.clone())
.child((self.build_content)(window, cx)),
)
.vertical_scrollbar_for(self.scroll_handle.clone(), window, cx),
)
.show_close_button(self.show_close_button)
.show_suppress_button(self.show_suppress_button)
.on_close(cx.listener(|_, suppress, _, cx| {
Expand Down
Loading