Revert: Spawn terminal process on background executor - #41060
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
agu-z
enabled auto-merge (squash)
October 23, 2025 23:28
|
Thank you for this fix! 🙏 |
Contributor
|
It seems like this has regressed again @agu-z? As of 212 I think, it seems like ctrl-c is no longer working for some processes in Nushell |
Member
|
What operating system? DO you have a concrete reproducer? We did reland the original PR with some fixes applied again |
Contributor
|
Simple reproduction: on 2025-11-07.15-04-55.movZed: v0.212.2 (Zed Preview) Edit: This occurs with bash too: |
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#41060) Reverts zed-industries#40774 and zed-industries#40824 since they introduce a bug where Nushell processes are leaked and Ctrl+C doesn't kill the current process. Release Notes: - Fix a bug where nushell processes wouldn't get killed after closing a terminal tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #40774 (and the dependent #40824) as it introduces a bug where Nushell processes are leaked and Ctrl+C doesn't kill the current process.
Release Notes: