pane: Ignore max tabs on terminal pane - #40740
Merged
JosephTLyons merged 5 commits intoOct 21, 2025
Merged
Conversation
Collaborator
|
We discussed adding a test as well to make sure we can open |
Collaborator
|
I pushed a few small changes:
|
JosephTLyons
force-pushed
the
fix/terminal-ignore-max-tabs
branch
from
October 21, 2025 00:48
fac09d3 to
d6ca860
Compare
JosephTLyons
force-pushed
the
fix/terminal-ignore-max-tabs
branch
from
October 21, 2025 00:53
d6ca860 to
05e8f86
Compare
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Closes zed-industries#39901 I'm unsure as to which direction the team wants to go with this, but this is the behavior of VSCode which is what this feature is based off so i'm going with this. Changes: 1. Introduced a new argument to the `new` method on the Pane called `ignore_max_tabs` that forces the `max_tabs` to None if it's true. 2. Added a new test `test_bypass_max_tabs_limit`. Release Notes: - Fixed: `max_tabs` Setting affecting the terminal pane. --------- Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39901
I'm unsure as to which direction the team wants to go with this, but this is the behavior of VSCode which is what this feature is based off so i'm going with this.
Changes:
newmethod on the Pane calledignore_max_tabsthat forces themax_tabsto None if it's true.test_bypass_max_tabs_limit.Release Notes:
max_tabsSetting affecting the terminal pane.