Skip to content

pane: Ignore max tabs on terminal pane - #40740

Merged
JosephTLyons merged 5 commits into
zed-industries:mainfrom
vipexv:fix/terminal-ignore-max-tabs
Oct 21, 2025
Merged

pane: Ignore max tabs on terminal pane#40740
JosephTLyons merged 5 commits into
zed-industries:mainfrom
vipexv:fix/terminal-ignore-max-tabs

Conversation

@vipexv

@vipexv vipexv commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Closes #39901

I'm unsure as to which direction the team wants to go with this, but this is the behavior of VSCode which is what this feature is based off so i'm going with this.

Changes:

  1. Introduced a new argument to the new method on the Pane called ignore_max_tabs that forces the max_tabs to None if it's true.
  2. Added a new test test_bypass_max_tabs_limit.

Release Notes:

  • Fixed: max_tabs Setting affecting the terminal pane.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 20, 2025
@JosephTLyons JosephTLyons self-assigned this Oct 20, 2025
@JosephTLyons

Copy link
Copy Markdown
Collaborator

We discussed adding a test as well to make sure we can open max_tabs + 1 terminal tabs, but if the terminal testing infra isn't there, in the same way it is in pane.rs, we can skip.

@JosephTLyons

JosephTLyons commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

I pushed a few small changes:

  1. I renamed ignore_max_tabs to use_max_tabs, to be affirmative (just a personal pref), and also flipped the bools at the call sites.
  2. Moved use_max_tabs up in the parameter list, as we tend to always end with window and cx, in methods that use those parameters, just an internal convention.

@JosephTLyons
JosephTLyons force-pushed the fix/terminal-ignore-max-tabs branch from fac09d3 to d6ca860 Compare October 21, 2025 00:48
@JosephTLyons
JosephTLyons force-pushed the fix/terminal-ignore-max-tabs branch from d6ca860 to 05e8f86 Compare October 21, 2025 00:53
@JosephTLyons
JosephTLyons merged commit 36c0068 into zed-industries:main Oct 21, 2025
21 checks passed
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Closes zed-industries#39901

I'm unsure as to which direction the team wants to go with this, but
this is the behavior of VSCode which is what this feature is based off
so i'm going with this.

Changes: 

1. Introduced a new argument to the `new` method on the Pane called
`ignore_max_tabs` that forces the `max_tabs` to None if it's true.
2. Added a new test `test_bypass_max_tabs_limit`.

Release Notes:

- Fixed: `max_tabs` Setting affecting the terminal pane.

---------

Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to open multiple terminal tabs

2 participants