vim: Fix hang in visual block motion - #40723
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
Member
Author
|
Leaving this in Will make sure to merge before our Wednesday Cutoff, so we can at least get the hang removed 🧹 |
The `vim::visual::Vim.visual_block_motion` method was recently updated in order to jump between buffer rows instead of display rows. However, with this now being the case, the `break` condition was never met when the motion was horizontal rather than vertical and soft wrapped lines were used. As such, this commit udpates the condition to ensure it's always reached, preventing the hanging from happening.
dinocosta
force-pushed
the
vim-visual-block-hang
branch
from
October 21, 2025 08:52
2e837f7 to
fe309c0
Compare
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
dinocosta
marked this pull request as ready for review
October 21, 2025 10:53
dinocosta
added a commit
that referenced
this pull request
Oct 21, 2025
The `vim::visual::Vim.visual_block_motion` method was recently updated (#39355) in order to jump between buffer rows instead of display rows. However, with this now being the case, the `break` condition was never met when the motion was horizontal rather than vertical and soft wrapped lines were used. As such, this commit udpates the condition to ensure it's always reached, preventing the hanging from happening. Release Notes: - Fixed hang in Vim's visual block motions when updating selections --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
The `vim::visual::Vim.visual_block_motion` method was recently updated (zed-industries#39355) in order to jump between buffer rows instead of display rows. However, with this now being the case, the `break` condition was never met when the motion was horizontal rather than vertical and soft wrapped lines were used. As such, this commit udpates the condition to ensure it's always reached, preventing the hanging from happening. Release Notes: - Fixed hang in Vim's visual block motions when updating selections --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vim::visual::Vim.visual_block_motionmethod was recently updated (#39355) in order to jump between buffer rows instead of display rows. However, with this now being the case, thebreakcondition was never met when the motion was horizontal rather than vertical and soft wrapped lines were used. As such, this commit udpates the condition to ensure it's always reached, preventing the hanging from happening.Release Notes: