windows: Revert "windows: Fix ascent/descent calculations (#40103)" - #40175
Merged
Conversation
This reverts commit f1db1f3.
cla-bot
Bot
added
the
cla-signed
cole-miller
enabled auto-merge (squash)
October 14, 2025 12:14
cole-miller
changed the title
cole-miller
disabled auto-merge
October 14, 2025 12:15
cole-miller
enabled auto-merge (squash)
October 14, 2025 12:15
cole-miller
disabled auto-merge
October 14, 2025 12:29
cole-miller
enabled auto-merge (squash)
October 14, 2025 12:29
|
I wonder if we should also revert this? #39886 Or this issue only happens in macOS? |
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ries#40103)" (zed-industries#40175) This reverts commit 1455bf9. This seems to have affected the vertical positioning of text that doesn't contain emojis in a way that was unintended. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f1db1f3.
This seems to have affected the vertical positioning of text that doesn't contain emojis in a way that was unintended.
Release Notes: