Skip to content

windows: Fix shader rotation order for pattern rendering - #39993

Merged
localcc merged 1 commit into
zed-industries:mainfrom
0x2CA:fix_windows_shader_rotation_mul
Oct 13, 2025
Merged

windows: Fix shader rotation order for pattern rendering#39993
localcc merged 1 commit into
zed-industries:mainfrom
0x2CA:fix_windows_shader_rotation_mul

Conversation

@0x2CA

@0x2CA 0x2CA commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

old

image

new

image

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 11, 2025
@github-actions github-actions Bot added the community champion Issues filed by our amazing community champions! 🫶 label Oct 11, 2025
@0x2CA

0x2CA commented Oct 11, 2025

Copy link
Copy Markdown
Contributor Author

The interface manifests itself in the wrong direction of rotation

The core of the problem is that the Row Major and Column Major of shaders are different for different platforms.

This leads to the need to pay special attention to the construction of matrices, and matrix multiplication directionality

Just a theoretical fix since I don't have a suitable build environment, need to test it out

@localcc
localcc merged commit a3bcf6f into zed-industries:main Oct 13, 2025
24 checks passed
@0x2CA
0x2CA deleted the fix_windows_shader_rotation_mul branch October 14, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants