acp_thread: If available, use git bash over powershell in terminal tool - #39466
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
Veykril
changed the title
Veykril
force-pushed
the
push-pztwqknoxntm
branch
2 times, most recently
from
October 3, 2025 14:35
846119d to
4baf56c
Compare
Veykril
commented
Oct 3, 2025
| os: std::env::consts::OS.to_string(), | ||
| arch: std::env::consts::ARCH.to_string(), | ||
| shell: get_default_system_shell(), | ||
| shell: ShellKind::new(&get_default_system_shell_preferring_bash()).to_string(), |
Member
Author
There was a problem hiding this comment.
This change makes it so we name the shell by name only in the prompt, not by path. That is:
/bin/shbecomes justsh/bin/bashbecomes justshC:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exebecomes justpowershellC:\Program Files\Git\bin\bash.exebecomes justsh
This feels more correct to me, the concrete path is not relevant for the agent as far as I can tell. Just the type of the shell
Veykril
force-pushed
the
push-pztwqknoxntm
branch
from
October 5, 2025 07:19
4baf56c to
4111996
Compare
Veykril
force-pushed
the
push-pztwqknoxntm
branch
2 times, most recently
from
October 6, 2025 09:08
71e7259 to
cfd98e3
Compare
Veykril
force-pushed
the
push-pztwqknoxntm
branch
from
October 6, 2025 09:51
cfd98e3 to
7c3302c
Compare
cole-miller
added a commit
that referenced
this pull request
Oct 13, 2025
This applies the same change as #39466 to the terminal codepath for external agents. Release Notes: - N/A Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
reflectronic
pushed a commit
that referenced
this pull request
Oct 14, 2025
This applies the same change as #39466 to the terminal codepath for external agents. Release Notes: - N/A Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ol (zed-industries#39466) Release Notes: - When git bash is installed, agents will now use that over powershell when invoking terminal commands
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#40150) This applies the same change as zed-industries#39466 to the terminal codepath for external agents. Release Notes: - N/A Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: