Add ACP support for Goose

[michaelneale]

goose is an agent that operates as an ACP server which works nicely with zed, this adds it as an external option alongside the others:

(FYI wrote this with goose - and gptoss:120B model mostly). This PR description is all my human fumbling however.

I didn't bother with an icon, I would love to add an svg one but read somewhere (can't recall where) best to discuss that so it fits in!

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @michaelneale on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @michaelneale on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @michaelneale on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @michaelneale on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[michaelneale]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[benbrandt]

@michaelneale this is really awesome! Exciting to see you able to do this so quickly!

I am seeing some weird behavior with tool calls though?

Maybe we can schedule some time to pair to make this look a little nicer? Would also love to chat to see if we can make the Rust library a bit more ergonomic (have some ideas, but would love to run them by you)

[alexhancock]

@benbrandt I'm also helping push on the ACP front for goose, so could join you and @michaelneale or if Mic is busy this week (I know he's at a company event) I could pair with you

@michaelneale Let us know

[michaelneale]

@alexhancock go for it if you have some timezone overlap with @benbrandt

@benbrandt yeah some repeated tool calls are expected, ideally it would show a little more (ie reading this, searching that etc) so that would help. Not sure what you mean in this case by the rust library? yeah happy to pair (if you and @alexhancock don't get to this week, then next week?)

[alexhancock]

@benbrandt I can pair tomorrow - I am on US eastern hours. let me know what works alexhancock @ block dot xyz

[michaelneale]

@alexhancock @benbrandt I think main thing is that tool calls in ACP on the goose side should return a bit more context that is meaningful to show, or return it in a way it can be folded away if it isn't super relevant? (instead of just the tool call name alone?)

[benbrandt]

@alexhancock and @michaelneale yeah basically if you take a look at the docs here: https://agentclientprotocol.com/protocol/tool-calls

You can call ToolCallUpdate multiple times to update the individual cards for each tool call. I would also recommend updating the labels/titles to something more informative than the tool call name if you can, and also updating the content to show the output of the tool call so people can look at it. That was the main issue I had when trying to figure out what Goose was actually doing.

[michaelneale]

nice, looks like @alexhancock PR helps with that nicely

[michaelneale]

@alexhancock @benbrandt how are the latest changes on the goose side working now - looking better?

[alexhancock]

@alexhancock @benbrandt how are the latest changes on the goose side working now - looking better?

main of goose should be better than it was for sure! @benbrandt if you want to try you could run it with:

  "agent_servers": {
    "goose": {
      "command": "cargo",
      "args": [
        "+nightly",
        "-Z",
        "unstable-options",
        "-C",
        "/Users/alexhancock/Development/goose",
        "run",
        "--bin",
        "goose",
        "acp"
      ],
      "env": {}
    }
  }

to run from goose source locally, or we'll have a release out within a day or so to run with normal goose acp installed from https://block.github.io/goose/docs/getting-started/installation

[bennetbo]

Closing this one, as we added support for adding ACP servers through extensions. Docs are here (Draft): #41609