Add support for encodings other than UTF-8 - #36497

Closed

EuclidDivisionLemma wants to merge 43 commits into

zed-industries:mainfrom

EuclidDivisionLemma:add_support_for_non_utf_encodings

Commits on Nov 1, 2025

Add a status indicator to indicate the current file's encoding. When clicked a modal view opens that lets user choose to either reopen or save a file with a particular encoding. The actual implemen…
EuclidDivisionLemma
committed
678605a
Implement the actual encoding selector. There are currently only two encodings in the selector used as placeholders, but more will be added in the future. As of now, the encoding picker is not actu…
EuclidDivisionLemma
committed
18cd271
refactor: `encoding` in `EncodingIndicator` is now an optional trait object
EuclidDivisionLemma
committed
6c25c99
Make the status bar encoding indicator update the encoding when an encoding from the selector is chosen.
EuclidDivisionLemma
committed
ee70462
Add a new `load_with_encoding` function to handle files with various encodings.
EuclidDivisionLemma
committed
d3e95b9
Add support for saving and opening files in different encodings. The implementation is now complete.
EuclidDivisionLemma
committed
12e21b5
feat: Make the encoding indicator appear only when an editor is open.
EuclidDivisionLemma
committed
1078f85
fix: Fix an issue which caused the focus to not be on `EncodingSelector` after an action was selected from `EncodingSaveOrReopenSelector`
EuclidDivisionLemma
committed
a61d94d
- Fix cargo clippy errors
EuclidDivisionLemma
committed
cca3bb8
Migrate from `encoding` to `encoding_rs`
EuclidDivisionLemma
committed
6e1a5fa
Fix cargo clippy errors
EuclidDivisionLemma
committed
93281b2
- Format code properly
EuclidDivisionLemma
committed
3b77f57
Fix issues caused by Cargo.lock
EuclidDivisionLemma
committed
009c4ea
Add a licence symlink
EuclidDivisionLemma
committed
81376dd
Add UTF-16 LE/BE support and remove unused serde code
EuclidDivisionLemma
committed
0e2eda0
Write BOM once for UTF-16 files
EuclidDivisionLemma
committed
27376e0
- Update encoding detection to automatically switch to UTF-16LE/BE if
EuclidDivisionLemma
committed
680a72b
Make the `EncodingSaveOrReopenSelector` open only when the current buffer is associated with a file
EuclidDivisionLemma
committed
2a193ae
Fix an error caused by UTF-16 BOM checking when there are no BOMs
EuclidDivisionLemma
committed
fb6ec66
- Remove unnecessary calls to `collect`
EuclidDivisionLemma
committed
dd5ddbf
- Remove `load_with_encoding` from the `Fs` trait and make appropriate
EuclidDivisionLemma
committed
591fe9f
Re-Add `load_with_encoding` method to the `Fs` trait
EuclidDivisionLemma
committed
9dc21f5
- Make `File::load` use `load_with_encoding`
EuclidDivisionLemma
committed
6561c89
Update `tests` in `copilot.rs` to match the new `load` method signature
EuclidDivisionLemma
committed
8063144
Pass file path to `EncodingSelector` via `Toggle` action, if there is
EuclidDivisionLemma
committed
13ea13b
Add a call to `open_abs_path` to enable opening of files from
EuclidDivisionLemma
committed
37754b0
- Return an error if the file contains invalid bytes for the specified
EuclidDivisionLemma
committed
44abaed
- Add a field `encoding` in both `Workspace` and `Project`
EuclidDivisionLemma
committed
183bff5
- Add optional encoding parameter to Worktree::load_file
EuclidDivisionLemma
committed
d515ddd
Clicking on `Choose another encoding` and selecting an encoding should
EuclidDivisionLemma
committed
0d3095a
Enable a file to be opened with an invalid encoding with the invalid
EuclidDivisionLemma
committed
b629b1f
Fix an issue that caused a reopened buffer to use UTF-8 even if the
EuclidDivisionLemma
committed
25c6af4
Fix an issue that caused the buffer to be in a modified state after
EuclidDivisionLemma
committed
0e38704
Create a new crate `encodings` that will have all that is not related to
EuclidDivisionLemma
committed
1d95a18
- Move the functionality in `fs::encodings` to a seperate crate
EuclidDivisionLemma
committed
8580683
- Fix an issue that caused UTF-8 to be used when a file was closed and
EuclidDivisionLemma
committed
b2187e5
Remove calls to `lock` and `unwrap` as they are no longer needed
EuclidDivisionLemma
committed
c130110
Fix conflicts
EuclidDivisionLemma
committed
0e89634
Fix conflicts
EuclidDivisionLemma
committed
19b06e5
Move the invalid encoding UI from `project` to `workspace`
EuclidDivisionLemma
committed
08032bd
- Use `EncodingOptions` for parameters
EuclidDivisionLemma
committed
0b942fe
Use `Buffer::update` and `Buffer::update_encoding` to set the `encoding`
EuclidDivisionLemma
committed
2e18a5b
- Change the order in which `cx` and `encoding` appear
EuclidDivisionLemma
committed
4330e5f