Fix vim increment/decrement for negative numbers without gaps - #35200
Closed
kjyv wants to merge 3 commits into
Closed
Fix vim increment/decrement for negative numbers without gaps#35200kjyv wants to merge 3 commits into
kjyv wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
kjyv
force-pushed
the
vim-increase-no-gaps
branch
from
July 28, 2025 13:34
0866a53 to
02e2a33
Compare
cla-bot
Bot
added
the
cla-signed
Contributor
kjyv
force-pushed
the
vim-increase-no-gaps
branch
from
July 28, 2025 15:50
c22e820 to
070527b
Compare
Member
|
Thanks! |
ConradIrwin
enabled auto-merge (squash)
August 15, 2025 03:40
Member
|
@kjyv Unfortunately it looks like this broke some of the other ctrl-x/ctrl-a tests. Let me know if you need help figuring them out, |
Member
|
Closing for now, but please feel free to re-open if you get time to work on this more. |
auto-merge was automatically disabled
August 26, 2025 03:34
Pull request was closed
5 tasks
dinodinu
pushed a commit
to dinodinu/zed
that referenced
this pull request
Jun 3, 2026
…ndustries#58327) Finally continuing from PR zed-industries#35200: I adapted the fix to the changed find_target() logic and added more tests for version strings like `0.82.46`. This is a different but similar fix compared to zed-industries#47356 for helix mode - not sure if this can and should be unified? Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) (should not affect UI at all) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#35193 Release Notes: - Fixed vim's increment (`ctrl-a`) and decrement (`ctrl-x`) commands skipping the number under the cursor in dotted strings like version numbers (e.g. `0.81.46`) and hyphened date strings (e.g. `2015-02-01`) --------- Co-authored-by: Stefan Bethge <kjyv@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: dino <dinojoaocosta@gmail.com>
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…ndustries#58327) Finally continuing from PR zed-industries#35200: I adapted the fix to the changed find_target() logic and added more tests for version strings like `0.82.46`. This is a different but similar fix compared to zed-industries#47356 for helix mode - not sure if this can and should be unified? Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) (should not affect UI at all) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#35193 Release Notes: - Fixed vim's increment (`ctrl-a`) and decrement (`ctrl-x`) commands skipping the number under the cursor in dotted strings like version numbers (e.g. `0.81.46`) and hyphened date strings (e.g. `2015-02-01`) --------- Co-authored-by: Stefan Bethge <kjyv@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: dino <dinojoaocosta@gmail.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ndustries#58327) Finally continuing from PR zed-industries#35200: I adapted the fix to the changed find_target() logic and added more tests for version strings like `0.82.46`. This is a different but similar fix compared to zed-industries#47356 for helix mode - not sure if this can and should be unified? Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) (should not affect UI at all) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#35193 Release Notes: - Fixed vim's increment (`ctrl-a`) and decrement (`ctrl-x`) commands skipping the number under the cursor in dotted strings like version numbers (e.g. `0.81.46`) and hyphened date strings (e.g. `2015-02-01`) --------- Co-authored-by: Stefan Bethge <kjyv@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: dino <dinojoaocosta@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ndustries#58327) Finally continuing from PR zed-industries#35200: I adapted the fix to the changed find_target() logic and added more tests for version strings like `0.82.46`. This is a different but similar fix compared to zed-industries#47356 for helix mode - not sure if this can and should be unified? Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) (should not affect UI at all) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#35193 Release Notes: - Fixed vim's increment (`ctrl-a`) and decrement (`ctrl-x`) commands skipping the number under the cursor in dotted strings like version numbers (e.g. `0.81.46`) and hyphened date strings (e.g. `2015-02-01`) --------- Co-authored-by: Stefan Bethge <kjyv@users.noreply.github.com> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: dino <dinojoaocosta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35193
Release Notes: