Add a CI check that Cargo.lock is up to date - #35111
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
cole-miller
force-pushed
the
check-lockfile-in-ci
branch
from
July 25, 2025 19:18
5ae53ba to
f92f243
Compare
orual
pushed a commit
to orual/zed
that referenced
this pull request
Aug 23, 2025
Should catch cases like zed-industries#33667 where a dependency was bumped in Cargo.toml without a corresponding lockfile update. (This can happen when committing from outside of Zed or if rust-analyzer isn't running.) Passing `--frozen --workspace` should ensure this doesn't fail just because there's a newer patch version of some third-party dependency, and prevent it from taking long. We only need to run this on macOS because Cargo.lock is platform-independent. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Should catch cases like zed-industries#33667 where a dependency was bumped in Cargo.toml without a corresponding lockfile update. (This can happen when committing from outside of Zed or if rust-analyzer isn't running.) Passing `--frozen --workspace` should ensure this doesn't fail just because there's a newer patch version of some third-party dependency, and prevent it from taking long. We only need to run this on macOS because Cargo.lock is platform-independent. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should catch cases like #33667 where a dependency was bumped in Cargo.toml without a corresponding lockfile update. (This can happen when committing from outside of Zed or if rust-analyzer isn't running.) Passing
--frozen --workspaceshould ensure this doesn't fail just because there's a newer patch version of some third-party dependency, and prevent it from taking long.We only need to run this on macOS because Cargo.lock is platform-independent.
Release Notes: