go: Write envFile properties back to env config - #34300
Merged
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Spissable on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Spissable
changed the title
envFile properties back to env configenvFile properties back to env config
maxdeviant
changed the title
envFile properties back to env configenvFile properties back to env config
Contributor
|
Oops sorry about that, thanks for plumbing those envs the rest of the way through. |
P1n3appl3
enabled auto-merge (squash)
July 11, 2025 18:13
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…4300) Closes zed-industries#32984 Note that while zed-industries#33666 did the reading of the `envFile` just fine, the read values were never passed along. This was mentioned by [this comment](zed-industries#33666 (comment)) and also confirmed by myself. With the changes here, I successfully debugged a project of mine and all the environment variables from my `.env` were present. Release Notes: - Fix Go debugger ignoring env vars from the envFile setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32984
Note that while #33666 did the reading of the
envFilejust fine, the read values were never passed along. This was mentioned by this comment and also confirmed by myself.With the changes here, I successfully debugged a project of mine and all the environment variables from my
.envwere present.Release Notes: