Autoscroll on paste - #24
Merged
Merged
Conversation
This also removes the `changed_selections` and moves the autoscroll request inside of `update_selections`. This is nicer because it'll force us to determine whether we want to autoscroll every time we update the selections, so that we don't forget this in the future.
1 task
Anthony-Eid
pushed a commit
to Anthony-Eid/zed
that referenced
this pull request
Aug 25, 2024
m-bers
pushed a commit
to m-bers/zed
that referenced
this pull request
Apr 19, 2026
…e-latest-zed Merge latest zed upstream paying close attention to and u...
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 14, 2026
…stries#24/zed-industries#25 and backlog items - Tick confirmed awaiting_testing items (interrupt-shows-✕, rerun-during-run, re-run-after-finish); stuck-running observation stays open. - Archive phases 21 (live counter), 22 (multi-select), 23 (collapse) — all confirmed working; remaining manual tests moved to awaiting_testing.md. - Bug zed-industries#24: rich outputs (tables/images/markdown/json) dropped on save, so outputs don't survive close/reopen (plain/stream/error round-trip fine). - Bug zed-industries#25: adding a cell at the viewport bottom doesn't scroll it into view. - Backlog: retain cell output through cut/paste and delete/undo; a per-cell "last executed time" indicator. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 14, 2026
…s#24) Rich outputs — pandas DataFrame tables (text/html), matplotlib images, markdown and JSON reprs — were silently dropped on save: their Output variants stored only the rendered view, so Output::to_nbformat returned None and the data never reached the .ipynb. Reopening a notebook then showed no outputs for any data work. Retain the source MimeBundle on the Image, Table, Markdown, and Json variants (captured in Output::new, where the bundle is already available and which every construction path funnels through) and serialize it back as DisplayData in to_nbformat. Rich outputs now round-trip through save/reopen; plain, stream, and error outputs already did. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 14, 2026
…/23; backfill changelog commit IDs - Bugs zed-industries#21 (spurious conflict toast) and zed-industries#24 (rich outputs dropped) confirmed fixed by the user; recorded in CHANGELOG.md and removed from bugs.md and the awaiting_testing pointer list. - Phase 17 fully done (stuck-running observation dismissed after 5+ phases with no recurrence) and Phase 23 done (output-collapse persistence confirmed now that zed-industries#24 is fixed) — both sections removed from awaiting_testing.md. - Refresh the zed-industries#22/zed-industries#23 test recipes for their follow-up fixes. - Backfill CHANGELOG.md with the implementation commit for every completed phase and confirmed bug. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 15, 2026
The snapshot pipeline already round-trips outputs end to end: copy/cut and the delete-undo record serialize cells via to_nbformat_cell (which has carried ALL outputs since bug zed-industries#24 retained rich outputs' source media), and paste/undo rebuild through Cell::load, which restores them. What was missing when the gap was reported pre-dated that fix. Adds test_cell_outputs_round_trip_through_snapshot (stream + plain-result + rich markdown outputs through load → snapshot) and an outputs() accessor on CodeCell for it. Phase 27 complete; phase 32 (notebook UX niceties: Esc collapses multi-selection, markdown preview render-on-exit, focus return after toolbar interactions) promoted to keep 5 phases in rotation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ll-on-paste Autoscroll on paste
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes we're adding an autoscroll request on paste that we missed in #18.
As part of this pull request, we are also removing the
BufferView::changed_selectionsmethod and inlining the autoscroll request inside ofupdate_selections. This is nicer because it'll force us to determine whether we want to autoscroll every time we update the selections, so that we don't forget to do so in the future./cc: @nathansobo @maxbrunsfeld