Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust editor: open excerpts split key binding #23646

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

JosephTLyons
Copy link
Collaborator

@JosephTLyons JosephTLyons commented Jan 25, 2025

The pattern in Zed and in other editors is to use cmd to modify some file-opening action to open it in a split rather than in the current pane.

  • In the project pane, a click opens a file, and a cmd-click opens it in a split
  • In the file finder, enter opens the file, and a cmd-enter opens it in a split

It makes sense to me that if alt-enter opens a file from the excerpt, that cmd-alt-enter opens it in a split, following the pattern above.

Note: I'm not auto-merging this, as others might disagree.
Note: I didn't touch the Vim binding.

Release Notes:

  • Breaking Change: Changed editor: open excerpts split key binding to cmd-alt-enter on macOS and ctrl-alt-enter on Linux.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 25, 2025
@zed-industries-bot
Copy link

Warnings
⚠️
Adjust `editor: open excerpts split` key binding
        ^

Write PR titles using sentence case.

Have feedback on this plugin? Let's hear it!

Generated by 🚫 dangerJS against e5fff60

@JosephTLyons JosephTLyons merged commit 21b4a0d into main Jan 25, 2025
13 checks passed
@JosephTLyons JosephTLyons deleted the adjust-`editor-open-excerpts-split`-key-binding branch January 25, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants