Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project_panel: Add directory auto-expand after 500ms hover during dragging #23080

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

0xtimsb
Copy link
Member

@0xtimsb 0xtimsb commented Jan 13, 2025

This PR resolves one part of issue #14496

In project panel, when dragging, if you hover over a directory for ~500ms, it now auto-expands so you can drag and drop into nested directories.

Task cleanup is handled in these cases:

  • Dragged onto a different entry.
  • Dragged anywhere else, and the 500ms timer runs out (for example, out of the project panel).
  • Dropped onto any entry.

I don’t see any edge cases where task isn’t cleaned up after 500ms.

auto-expand.mp4

Release Notes:

  • Added auto-expand for directories on hover for a while during dragging.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 13, 2025
@ConradIrwin
Copy link
Member

Thanks for this!

The timeout might be a bit short, but let's try it out and see if it causes problem in real life.

@ConradIrwin ConradIrwin merged commit 21e7765 into zed-industries:main Jan 17, 2025
14 checks passed
@JosephTLyons
Copy link
Collaborator

Just compiled main and tried this and it's such a nice QoL improvement! Thanks Smit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants