nix: Build using nixpkgs package#22825
Closed
WeetHet wants to merge 2 commits intozed-industries:mainfrom
Closed
Conversation
cla-bot
bot
added
the
cla-signed
Contributor
Author
Contributor
Author
|
Closing in favour of #22897 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the build to use the package definition from nixpkgs with a number of overrides, namely allowing the usage of
builtins.fetchGitand using the sources from the repo. While this technically makes zed a downstream of nixpkgs in this regard, the build process is fairly stable and the current situation is a lot worse anywaysRelease Notes: