Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search match highlight and occurrence style #1868

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

iamnbutler
Copy link
Member

@iamnbutler iamnbutler commented Nov 9, 2022

Description of feature or change

We won't be able to style active and inactive matches differently until we finish this task: #1869

Before | After
CleanShot - 2022-11-09 at 18 19 25@2x
CleanShot - 2022-11-09 at 18 19 54@2x
CleanShot - 2022-11-09 at 18 20 17@2x

Link to related issues from zed or insiders

Before Merging

  • Does this have tests or have existing tests been updated to cover this change?
  • Have you added the necessary settings to configure this feature?
  • Has documentation been created or updated (including above changes to settings)?

@iamnbutler iamnbutler merged commit c0d67d9 into main Nov 9, 2022
@iamnbutler iamnbutler deleted the readd-search-match-highlight branch November 9, 2022 23:37
maxbrunsfeld pushed a commit that referenced this pull request Nov 10, 2022
…ight

Update search match highlight and occurrence style
maxbrunsfeld pushed a commit that referenced this pull request Nov 10, 2022
…ight

Update search match highlight and occurrence style
ConradIrwin added a commit that referenced this pull request Sep 8, 2023
The major change here is a refactoring to allow controling the save
behaviour when closing items, which is pre-work needed for vim command
palette.

For zed-industries/community#1868

Release Notes:

- vim: Add `ZZ` and `ZQ` to close the current item.
([#1868](https://github.com/zed-industries/community/issues/1868))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant