Make the application menu dispatch commands on the focused view - #14
Merged
Conversation
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
1 task
Anthony-Eid
pushed a commit
to Anthony-Eid/zed
that referenced
this pull request
Aug 7, 2024
1 task
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
- Fix #9: ToolPermissionContext::input_value now includes both source and destination paths formatted as 'source -> destination' for copy_path and move_path tools. Updated doc comments in tool_permissions.rs and settings_content/agent.rs. Added CopyPathTool to path pattern extraction in build_permission_options. - Fix #14: Replaced .ok() on unbounded_send calls in authorize_third_party_tool and authorize methods with explicit error logging.
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
Replace 41 instances of .ok() and let _ = on fallible operations with .log_err() for visibility. Includes unbounded_send, terminal operations, and file system operations throughout the visual test runner.
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
…y rules Move HardcodedSecurityRules, HARDCODED_SECURITY_RULES, HARDCODED_SECURITY_DENIAL_MESSAGE, and check_hardcoded_security_rules to agent_settings so both agent and agent_servers can use them. The moved function returns Option<String> and accepts extracted_commands as a parameter, allowing the agent crate to pass parsed sub-commands while the ACP code passes None.
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
Update copy_path and move_path regex_explanation to clarify independent matching. Update generic placeholder text from 'Enter a rule...' to 'Enter a tool input to test your rules...'. Also fix import of HARDCODED_SECURITY_RULES to come from agent_settings after Fix #14.
m-bers
pushed a commit
to m-bers/zed
that referenced
this pull request
Apr 19, 2026
…on-banner-helix fix: disable migration banner in Helix builds
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 10, 2026
Create four new planned phases drawn from the backlog and bugs: - Phase 12: create & open new notebooks (empty-file template + New Notebook). - Phase 13: per-cell hover/selection toolbar. - Phase 14: save-conflict guard + reload affordance (with bug zed-industries#14). - Phase 15: cell output & execution-state management. Repoint the moved backlog items at their phases and mark the a/b command-mode item done via bug zed-industries#13. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
ShalashaskaOcelot
pushed a commit
to ShalashaskaOcelot/zed
that referenced
this pull request
Jul 12, 2026
…nter reset (phases 14, 15) Gutter: center the run button, execution number, and output ellipsis between the indicator bar and the cell edge instead of the full gutter width, so the button no longer sits tight against the bar. Phase 14 (data safety): track when the .ipynb changed on disk under unsaved changes; while flagged, saving prompts Overwrite/Cancel instead of silently overwriting (bug zed-industries#14). Add a "Reload Notebook" command (palette + More options) that prompts when dirty, and a Reload button on the conflict toast. Conflict state clears on reload or confirmed overwrite. Phase 15 (execution state): kernel restart clears each cell's stale In [N] execution number (interrupt does not); new ClearCellOutputs action clears the selected cell's outputs (palette + More options; no default keybind since no standard combo exists). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eseBDGa7au9r2VxBHeh9X
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Make the application menu dispatch commands on the focused view
yunxinx
added a commit
to yunxinx/zed
that referenced
this pull request
Sep 2, 2026
- line_break 不再维护独立的 is_legacy_word_character，改为复用 LineWrapper::is_word_char，消除两份词表与 dead_code - 上游 zed-industries#62743 的 ASCII 收尾标点（! ) ] } "）不在行首规则随之进入 UAX zed-industries#14 断行策略 - 补充收尾标点、开引号与路径分隔符的断行回归测试
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the application menu could only dispatch global commands. Also, the command dispatch is now handled automatically by
gpui, instead of being wired up in Zed'smainfunction.🍐 'd with @nathansobo