Reveal in files instead of Finder

[francesco-gaglione]

fixes: #12776

Release Notes:

• Renamed editor::RevealInFinder to editor::RevealInFileManager

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @francesco-gaglione on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[francesco-gaglione]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[mrnugget]

If we're doing a rename, I think we should use the generic term file manager. Finder/Files are specific application names.

[francesco-gaglione]

@mrnugget working on it

[francesco-gaglione]

• Rename Reveal in Finder context menu option to something more generic #13322
  Reference

[mikayla-maki]

I don't think we should do a rename, I'd prefer if we added actions for each operating system, and then used cfg!()to switch between which actions we register and use in the UI.

[mikayla-maki]

Essentially, this would mean wrapping each .on_action or .action with something like .when(cfg!(target_os = "OPERATING SYSTEM"), |this| { this.action(/*....*/) })

[francesco-gaglione]

@mikayla-maki wrapped actions with your suggestion. Check it if it is enough. Thank you.

[francesco-gaglione]

This pr can be merged or I have to solve conflicts first?

[mrnugget]

This pr can be merged or I have to solve conflicts first?

I think rebasing on main (or merging it in) and fixing the conflicts would be great.

[francesco-gaglione]

@mrnugget done it. so we can merge?

[francesco-gaglione]

I don't have a mac can anyone test before merging?

[mrnugget]

I tested on Linux and on macOS. On Linux everything works as expected. On macOS the action is now called "Reveal in File Manager".

I think @mikayla-maki's idea was that we define two actions: RevealInFinder and RevealInFileManager and only use one of two, depending on the target dir. (Also: reveal_in_finder is still the method name.)

The problem is that for the vim.json keybindings we have to pick one over the other and we can't do a runtime check of vim.enabled to define one or the other action.

Sooooo, should we go with the rename then, @mikayla-maki? :D

[mikayla-maki]

@mrnugget Agreed! Thanks for bringing that issue to my attention :)