Not all typescript problems are found/visible in the problem panel

[nym21]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

The problem panel only show a certain amount of problems while the command tsc --noEmit --skipLibCheck will show all the problems found.

Environment

Maybe a way to specify a command for problems but I would expect the editor to automatically run tsc when in a Typescript project.

VSCode has for example a typescript.tsserver.experimental.enableProjectDiagnostics option. (microsoft/vscode#13953)

While one solution would be to just run tsc in a terminal, it's not possible for now to split a terminal panel (in v.0.123.3) vertically and thus isn't practical to have to choose between having the server or the problems visible at any time.

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[anandthakker]

It looks like 2727f55 fixed a bug wherein the initialization_options setting was not being respected for vtsls (the default TS language server).

Once that makes it into a release, it will be possible to turn this on in settings like:

"lsp": {
    "vtsls": {
      "initialization_options": {
        "typescript": {
          "tsserver": {
            "experimental": {
              "enableProjectDiagnostics": true
            }
          }
        }
      }
    }
  }

[nym21]

Thanks a lot, can't wait !

[brookback]

This is still not working for me. I'm not sure if this is intended behaviour, but the Zed marketing pages says so ("Project wide diagnostics").

It's easily reproducible by creating a new Typescript project:

mkdir repro && cd repro
npm init -y
npm i --save-dev typescript
npx tsc --init
# Won't type check:
echo "let a: string = 1;" > file.ts
zed .

If I open file.ts, the problems pane shows error. When closed, the problem pane shows "No errors".

Here's the relevant Zed settings.json:

Details

{
    "lsp": {
        "vtsls": {
            "initialization_options": {
                "preferences": {
                    "includeInlayParameterNameHints": "all",
                    "includeInlayParameterNameHintsWhenArgumentMatchesName": true,
                    "includeInlayFunctionParameterTypeHints": true,
                    "includeInlayVariableTypeHints": true,
                    "includeInlayVariableTypeHintsWhenTypeMatchesName": false,
                    "includeInlayPropertyDeclarationTypeHints": true,
                    "includeInlayFunctionLikeReturnTypeHints": true,
                    "includeInlayEnumMemberValueHints": true
                },
                "typescript": {
                    "tsserver": {
                        "experimental": {
                            "enableProjectDiagnostics": true
                        }
                    }
                }
            }
        }
    }
}

[JumppanenTomi]

I'm not sure if any of you still have this problem, but I managed to fix exactly same problem with this config:

"lsp": {
    "vtsls": {
      "settings": {
        "typescript": {
          "tsserver": {
            "experimental": {
              "enableProjectDiagnostics": true
            }
          }
        }
      }
    }
  }

[brookback]

@JumppanenTomi So you can't repro my example above? I can still repro it with that config shape you posted :/ I.e. I won't get project wide diagnostics unless the bad file is opened.