-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project panel directory closes when installing project dependencies #13762
Comments
It looks like this is caused by #13072. I wonder if id reuse logic introduced by that PR is not causing us to assign a new node id to the root entry, thus leading project panel to collapse the whole worktree. /cc @mikayla-maki |
This has been bugging me so badly, but I don't know Rust well and can't fix it myself with a PR :( |
Note that this happens outside the terminal as well (seemingly random in many cases) |
I've observed this behaviour whenever the git module reindexes the project, which you can see with trace logging: RUST_LOG=worktree=trace /Applications/Zed.app/Contents/MacOS/zed |
I also noticed this when editing javascript files. |
Is there any update on this ? it makes using zed pretty difficult |
To be honest it shouldn't shrink on its own unless the user commands such an action, I think the issue should be renamed as it doesn't truly address the problem |
This issue has been happening to me for a while. It isn't when I'm pressing any keys. I'm on an M1 Mac, and editing JS files. |
I agree that the title isn't great. I accidentally created a duplicate of this because I didn't see how this title could have been the same as my problem. |
Fixing this should probably be a higher priority than it is |
I had the same problem, but it stopped occurring. Either because of some kind of fix or because I changed Git-client, currently working with GitButler (which I can really recommend!) |
I love Zed but this is making the editor completely unusable. |
I think I found the culprit (at least on my system). I'm on MacOS and normally develop in My theory is that it's to do with iCloud Drive compatibility issues. No idea why, but it'd make sense given that writes to the filesystem seem to trigger the tree collapsing behaviour for me. Hopefully this helps someone else too! EDIT: To clarify - iCloud Drive synchronises |
This also happens in the Desktop folder, though moving a project to a root folder isn't ideal by any means |
@Moosems Desktop is an iCloud Drive synchronised directory. ![]() |
Right |
Can I give you a big hug 🤗 , @petehayes102 ?! So far so good on my end with the same fix (was in |
Can confirm that the issue happens on MacOS when the directory is iCloud-synchronized. To me it happens almost all the time. Simply saving a file with some changes causes it. |
@JosephTLyons ping on this one. starting to more widely affect the team. |
osiewicz I have the same problem as well, the team should prioritize fixing this issue because it is really annoying for macos users. I love the simplicity and customization and im using it as my main text editor right now(instead of neovim), but i only have this issue and it's not minor at all, the view panel randomly just collapses all the time. Edit: I removed all my github projects from icloud and the issue is fixed, but still this should be fixed. |
This issue has been made worse with the 0.147.2 build Now the root folder will collapse randomly when editing a file |
I have this problem too, it makes using Zed unusable. Moving working directory to the different location doesn't help. Does anybody still have this issue? It looks like to be a critical issue, but the last message is 2 weeks old. |
I believe this is fixed in |
thanks for your work getting this resolved |
I've had this issue for a while now, working with js files, all I need to
do is update the file and save it, and the project tree collapses. There
has been a lot of different discussions about related issues, but it still
hasn't been resolved. I've moved back to another editor now, but hope it
gets fixed in the future.
…On Mon, Aug 26, 2024 at 18:30:45, joshuaia ***@***.***> wrote:
I have this problem too, it makes using Zed unusable. Moving working
directory to the different location doesn't help.
Does anybody still have this issue? It looks like to be a critical issue,
but the last message is 2 weeks old.
I'm wondering how did you manage to find a workaround.
—
Reply to this email directly, view it on GitHub
<#13762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARSFWYMNT4IDTSJEK3W3J6TZTO3CLAVCNFSM6AAAAABKI2UTS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRGI4DKMBWGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
The bug is still there. To reproduce:
I can't work that way. |
@matthieuHenocque unless you're building Zed from source, this fix will be available starting with tomorrows Preview build (and next weeks Stable) |
still happening to me with Zed 0.152.3 on Sonoma 14.6.1 - iCloud drive synchronised Documents folder and projects inside of ~/Documents/something/some_project - Go projects and Hugo projects (but that seem irrelevant)... |
Just had a friend message me and say they saw this bug again the other day - they think it is a regression. Is anyone else seeing this bug again? |
@JosephTLyons No I can't replicate on latest stable (0.155.2). |
I can still replicate this issue on subdirectories on the latest preview build (as of writing this). @JosephTLyons I'll DM you a video of this happening, as I can't share the repo contents publicly. |
It's probably nothing but I did upgrade to MacOS 15 in the intervening period between tests. Might be worth considering if you're drawing a blank. |
fwiw I have no upgraded MacOS. Still on Ventura 13.3.1 (a) . @JosephTLyons video was sent in X DM on Oct 2nd. |
A video of this happening on a private repo can be found in our company Slack here. |
Check for existing issues
Describe the bug / provide steps to reproduce it
@blocksuite/[email protected]
@blocksuite/[email protected]
@blocksuite/[email protected]
Environment
Zed: v0.141.3 (Zed)
OS: macOS 14.5.0
Memory: 36 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
CleanShot.2024-07-03.at.13.45.53.mp4
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.Zed.log
The text was updated successfully, but these errors were encountered: