Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project panel directory closes when installing project dependencies #13762

Open
1 task done
jizhi0v0 opened this issue Jul 3, 2024 · 34 comments
Open
1 task done

Project panel directory closes when installing project dependencies #13762

jizhi0v0 opened this issue Jul 3, 2024 · 34 comments
Assignees
Labels
bug [core label] project panel Feedback for files tree view terminal Feedback for terminal integration, shell commands, etc

Comments

@jizhi0v0
Copy link

jizhi0v0 commented Jul 3, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  1. open terminal
  2. run bun install
    @blocksuite/[email protected]
    @blocksuite/[email protected]
    @blocksuite/[email protected]
  3. then you can see the left panel automatically shrinks but does not automatically expand

Environment

Zed: v0.141.3 (Zed)
OS: macOS 14.5.0
Memory: 36 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

CleanShot.2024-07-03.at.13.45.53.mp4

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
[Zed.log](https://github.com/user-attachments/files/16077608/Zed.log)
@osiewicz
Copy link
Contributor

osiewicz commented Jul 3, 2024

It looks like this is caused by #13072. I wonder if id reuse logic introduced by that PR is not causing us to assign a new node id to the root entry, thus leading project panel to collapse the whole worktree. /cc @mikayla-maki

@Moosems
Copy link

Moosems commented Jul 3, 2024

This has been bugging me so badly, but I don't know Rust well and can't fix it myself with a PR :(

@Moosems
Copy link

Moosems commented Jul 5, 2024

Note that this happens outside the terminal as well (seemingly random in many cases)

@petehayes102
Copy link

I've observed this behaviour whenever the git module reindexes the project, which you can see with trace logging:

RUST_LOG=worktree=trace /Applications/Zed.app/Contents/MacOS/zed

@JosephTLyons JosephTLyons added project panel Feedback for files tree view and removed triage labels Jul 8, 2024
@JustinLiang90
Copy link

I also noticed this when editing javascript files.

@JackMatthewRimmer
Copy link

Is there any update on this ? it makes using zed pretty difficult

@Moosems
Copy link

Moosems commented Jul 15, 2024

To be honest it shouldn't shrink on its own unless the user commands such an action, I think the issue should be renamed as it doesn't truly address the problem

@mattayersnz
Copy link

This issue has been happening to me for a while. It isn't when I'm pressing any keys. I'm on an M1 Mac, and editing JS files.

@Duclearc
Copy link

I agree that the title isn't great. I accidentally created a duplicate of this because I didn't see how this title could have been the same as my problem.
But this is happening so often (many times per day) it makes Zed extremely painful to use.

@Moosems
Copy link

Moosems commented Jul 16, 2024

Fixing this should probably be a higher priority than it is

@andrebaerlocher
Copy link

I had the same problem, but it stopped occurring. Either because of some kind of fix or because I changed Git-client, currently working with GitButler (which I can really recommend!)

@raphaellaude
Copy link

I love Zed but this is making the editor completely unusable.

@JosephTLyons JosephTLyons changed the title The left panel automatically shrinks and does not automatically expand Project panel directory closes when installing project dependencies Jul 23, 2024
@JosephTLyons JosephTLyons added the terminal Feedback for terminal integration, shell commands, etc label Jul 23, 2024
@petehayes102
Copy link

petehayes102 commented Jul 24, 2024

I think I found the culprit (at least on my system). I'm on MacOS and normally develop in ~/Documents/projects, but by moving to ~/projects, I don't have this issue anymore.

My theory is that it's to do with iCloud Drive compatibility issues. No idea why, but it'd make sense given that writes to the filesystem seem to trigger the tree collapsing behaviour for me. Hopefully this helps someone else too!

EDIT: To clarify - iCloud Drive synchronises ~/Documents, but it does not synchronise the whole user home dir. Moving to any location outside of an iCloud Drive synchronised dir should work.

@Moosems
Copy link

Moosems commented Jul 25, 2024

This also happens in the Desktop folder, though moving a project to a root folder isn't ideal by any means

@petehayes102
Copy link

@Moosems Desktop is an iCloud Drive synchronised directory.

Screenshot 2024-07-25 at 11 19 20 AM

@Moosems
Copy link

Moosems commented Jul 25, 2024

Right

@raphaellaude
Copy link

I think I found the culprit (at least on my system). I'm on MacOS and normally develop in ~/Documents/projects, but by moving to ~/projects, I don't have this issue anymore.

Can I give you a big hug 🤗 , @petehayes102 ?! So far so good on my end with the same fix (was in ~/Documents/GitHub). Thank you! Was driving me crazy

@chipmusic
Copy link

Can confirm that the issue happens on MacOS when the directory is iCloud-synchronized. To me it happens almost all the time. Simply saving a file with some changes causes it.

@shellscape
Copy link

@JosephTLyons ping on this one. starting to more widely affect the team.

@spirosmaggioros
Copy link

spirosmaggioros commented Aug 1, 2024

Can confirm that the issue happens on MacOS when the directory is iCloud-synchronized. To me it happens almost all the time. Simply saving a file with some changes causes it.

osiewicz I have the same problem as well, the team should prioritize fixing this issue because it is really annoying for macos users. I love the simplicity and customization and im using it as my main text editor right now(instead of neovim), but i only have this issue and it's not minor at all, the view panel randomly just collapses all the time.
We can't just remove the projects from icloud because of an editor

Edit: I removed all my github projects from icloud and the issue is fixed, but still this should be fixed.

@matthieuHenocque
Copy link

This issue has been made worse with the 0.147.2 build

Now the root folder will collapse randomly when editing a file

@joshuaia
Copy link

I have this problem too, it makes using Zed unusable. Moving working directory to the different location doesn't help.

Does anybody still have this issue? It looks like to be a critical issue, but the last message is 2 weeks old.
I'm wondering how did you manage to find a workaround.

@maxbrunsfeld
Copy link
Collaborator

maxbrunsfeld commented Aug 27, 2024

I believe this is fixed in

@shellscape
Copy link

thanks for your work getting this resolved

@mattayersnz
Copy link

mattayersnz commented Aug 27, 2024 via email

@matthieuHenocque
Copy link

The bug is still there.

To reproduce:

  • fresh install Zed
  • open a project folder and open the project panel
  • open any javascript file (mine is in a folder named modules at the root of the project)
  • make some edits

I can't work that way.

@osiewicz
Copy link
Contributor

osiewicz commented Aug 27, 2024

@matthieuHenocque unless you're building Zed from source, this fix will be available starting with tomorrows Preview build (and next weeks Stable)

@SnapshotCiTy
Copy link

still happening to me with Zed 0.152.3 on Sonoma 14.6.1 - iCloud drive synchronised Documents folder and projects inside of ~/Documents/something/some_project - Go projects and Hugo projects (but that seem irrelevant)...

@JosephTLyons
Copy link
Collaborator

Just had a friend message me and say they saw this bug again the other day - they think it is a regression. Is anyone else seeing this bug again?

@petehayes102
Copy link

@JosephTLyons No I can't replicate on latest stable (0.155.2).

@shellscape
Copy link

I can still replicate this issue on subdirectories on the latest preview build (as of writing this). @JosephTLyons I'll DM you a video of this happening, as I can't share the repo contents publicly.

@petehayes102
Copy link

It's probably nothing but I did upgrade to MacOS 15 in the intervening period between tests. Might be worth considering if you're drawing a blank.

@shellscape
Copy link

fwiw I have no upgraded MacOS. Still on Ventura 13.3.1 (a) . @JosephTLyons video was sent in X DM on Oct 2nd.

@JosephTLyons
Copy link
Collaborator

A video of this happening on a private repo can be found in our company Slack here.

@JosephTLyons JosephTLyons reopened this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] project panel Feedback for files tree view terminal Feedback for terminal integration, shell commands, etc
Projects
No open projects
Archived in project
Development

No branches or pull requests