Re-add Meson language support - #4980
Conversation
MrSubidubi
left a comment
There was a problem hiding this comment.
Thank you for picking this up!
Regarding the two language servers - we should allow the user to in theory choose any of the available language servers. https://github.com/zed-extensions/kotlin can serve as an example for this, e.g. you can declare support for multiple language servers in the extension.toml. With that, you can get rid of the settings.rs and users can use builtin methods to choose which language servers to run.
We can then tune the knobs in Zed itself, e.g. zed-industries/zed#40776 can be used to configure the default language server.
What do you think? I think if the extension provides 2 language servers, it should also declare both of these properly
|
Hello again, I have updated the extension with you suggestions above. You can now do something like: As far as I am concerned, the extension is ready to be published 😁 I was wondering if there is a way to make Thanks for the suggestion @MrSubidubi |
We lack a good way for this to come from the side of extensions currently, but you can shoot us an upstream PR in the Zed repo to change the default settings and I'll take a look! |
|
Could you also update the submodule here to the latest commit? I can otherwise do that tomorrow |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Job Paardekooper.
|
|
Ok, should be updated now I think |
MrSubidubi
left a comment
There was a problem hiding this comment.
Looks much better, thank you!
Lastly, I do have some concerns in how the downloading of new language servers is handled - usually, extensions use some of our APIs to auto-update the server if needed and also delete older versions upon a fresh download - see https://github.com/zed-extensions/elixir/blob/main/src/elixir.rs as an example for an extension that does this.
That said, I do not consider this a strict blocker here - would you be fine with merging now and adding/fixing this soon as a follow-up? Happy to also wait briefly if you want to fix this now. Thanks!
|
Thanks for the feedback. I think we can merge this now and I will do a follow-up update. |
MrSubidubi
left a comment
There was a problem hiding this comment.
Alright, sounds good. Thank you!
Add an extension to support the Meson build system after the existing Meson zed extension was no longer maintained and removed. Please view zed-industries#4532 for the full context of adding this extension. @MrSubidubi
Add an extension to support the Meson build system after the existing Meson zed extension was no longer maintained and removed. Please view zed-industries#4532 for the full context of adding this extension. @MrSubidubi
Add an extension to support the Meson build system after the existing Meson zed extension was no longer maintained and removed.
Please view #4532 for the full context of adding this extension.
@MrSubidubi