This repository has been archived by the owner on Apr 6, 2024. It is now read-only.
Use gloo_utils instead of the serde feature in wasm_bindgen to convert objects. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes worker to use gloo_utils package, rather than relying on the deprecated serde option in wasm-bindgen.
Description of the cyclic reference issue that I was hitting is here:
tkaitchuck/aHash#95
wasm_bindgen::JsValue::from_serde and wasm_bindgen::JsValue::into_serde are deprecated here (citing the cyclic reference issue that I encountered).
rustwasm/wasm-bindgen#3031
This patch replaces the usage of wasm_bindgen::JsValue::from_serde and wasm_bindgen::JsValue::into_serde with gloo_utils::format::JsValueSerdeExt::from_serde and gloo_utils::format::JsValueSerdeExt::into_serde respectively.