Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full dark theme #811

Closed
eromoe opened this issue Nov 2, 2017 · 13 comments · Fixed by #1495
Closed

Full dark theme #811

eromoe opened this issue Nov 2, 2017 · 13 comments · Fixed by #1495

Comments

@eromoe
Copy link

eromoe commented Nov 2, 2017

Previous issue #466 add Dark Mode which only make main window dark. But that looks incongruous with other parts, especially left sidebar looks too shinning in dark mode.

Hope can embed a full dark theme .

@oblitum
Copy link

oblitum commented Nov 4, 2017

Does this make sense? I think it would require a lot of UI rewriting to achieve or design a stylesheet? Maybe it's just better left as it is currently, at user option to match widgets with the system or specific style:

@trollixx
Copy link
Member

trollixx commented Nov 5, 2017

@oblitum I guess this is more of an issue for Windows users, who do not have all the flexibility Linux DEs provide.

Styling Qt apps works on Windows as well, but most people are just not aware of it. So, I think the first step would be providing some docs on how to change Zeal's appearance with third party themes for Qt.

@trollixx
Copy link
Member

trollixx commented Dec 5, 2017

I haven't tried QDarkStyleSheet yet, but it looks promising.

@oblitum
Copy link

oblitum commented Dec 5, 2017

Agreed!

@nzig
Copy link

nzig commented May 14, 2021

For those still looking for a solution:
Installing Kvantum worked for me. Note that after installing you need to follow the instructions on setting it as the default.

@ezxpro
Copy link

ezxpro commented Jun 8, 2021

For those still looking for a solution:
Installing Kvantum worked for me. Note that after installing you need to followe the instructions on setting it as the default.

For those on Windows, no solution, apparently.

I don't understand why make a darkmode that only applies to a certain part of the window, but anyways.

@oblitum
Copy link

oblitum commented Jun 9, 2021

I don't understand why make a darkmode that only applies to a certain part of the window, but anyways.

@ezxpro because people with decent OS can then couple it to their dark desktop environment.

Zeal can only do its best to provide flexibility where it can (Qt styling), not where it cannot (Window decorations), that's generally responsibility of the OS.

@ashb
Copy link

ashb commented Sep 14, 2022

QT tacking bug here https://bugreports.qt.io/browse/QTBUG-72028?focusedCommentId=677819&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-677819:

Note for those wanting to enable the experimental dark mode support (much improved in upcoming 6.4) for your application from code: you can call

qputenev("QT_QPA_PLATFORM", "windows:darkmode=1/2");

in your main function before instantiating Q(Gui)Application.

  • darkmode=1 means: dark window frame if the palette is explicitly made dark (background color darker than foreground color) and the system runs in dark mode.
  • darkmode=2 means: the palette is dark, based on system colors; the Window Vista style is still ignoring that, using the UXTheme provided control primitives (and there is no native API to get dark versions of those, to my knowledge). Fusion style looks quite good though

@K8-and-a-half-1000
Copy link

@ezxpro because people with decent OS can then couple it to their dark desktop environment.

If that's the case, Zeal should not support Windows at all, so a different project can fill in the gap.
Only half-supporting a platform ensures no-one will use it on that platform, an no alternatives get build over time.

@trollixx
Copy link
Member

trollixx commented Apr 16, 2023

Looks like with Qt 6.5 we can get a dark mode support with Fusion theme. It doesn't look native but not too bad overall. To be honest, Qt never got Windows Vista style to look native either. I think falling back to the Fusion theme is a good compromise.

@trollixx
Copy link
Member

Sneak peek below. Also includes native Chromium dark mode.

image

The Fusion style looks quite good in the light mode too:

image

I am kind of inclined to make Fusion the default style on Windows.

trollixx added a commit that referenced this issue Apr 30, 2023
This enables dark mode support.

Fixes #811.
@ruslaniv
Copy link

Sneak peek below. Also includes native Chromium dark mode.

Ok, great, but how can I use it on Windows?!
I'm still getting this horrendous glaring white sidebar on the left and on the top even when setting the mode to Dark in version 0.6.1

image

@trollixx
Copy link
Member

trollixx commented Aug 8, 2023

@ruslaniv this change is available in the main branch. You can try CI builds until new version is released. Binary artifacts are attached to each build.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

8 participants