Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember docset issue #1160

Closed
sinankeskin opened this issue Nov 13, 2019 · 6 comments
Closed

Ember docset issue #1160

sinankeskin opened this issue Nov 13, 2019 · 6 comments

Comments

@sinankeskin
Copy link

In ember docset some functions search throws error message:

Error opening C:/Users/Khons/AppData/Local/Zeal/Zeal/docsets/EmberJS.docset/Contents/Resources/Documents/api.emberjs.com/ember/3.13/functions/@ember%252Futils/isBlank.html: System cannot find the specified path

And yes this path is not exist.

Original path is:

C:\Users\Khons\AppData\Local\Zeal\Zeal\docsets\EmberJS.docset\Contents\Resources\Documents\api.emberjs.com\ember\3.13\functions@ember%2Futils\isBlank.html

Something weird with %252F and %2F

Thank you.

@trollixx
Copy link
Member

%252F is a double encoded forward slash, and instead of translating it into %2F, QUrl converts to %25252F instead.

The original URL is: https://api.emberjs.com/ember/3.13/functions/@ember%2Futils/isBlank

@trollixx
Copy link
Member

trollixx commented Dec 3, 2019

Okay, I have it working with my PoC built-in HTTP server. So far wasn't able to spot issues with any docsets, might push the change after a bit of more testing.

@trollixx trollixx added this to the 0.7.0 milestone Dec 3, 2019
@trollixx trollixx self-assigned this Jan 3, 2020
trollixx added a commit to trollixx/zeal that referenced this issue Jan 28, 2020
@trollixx
Copy link
Member

I've create PR #1182, which should address this bug, please test.

trollixx added a commit to trollixx/zeal that referenced this issue Jan 28, 2020
@sinankeskin
Copy link
Author

Unfortunately I can't test that. I don't have the environment to compile. Sorry and thank you for the effort.

@trollixx
Copy link
Member

AppVeyor produces binary artifacts for everything, for this PR you can pick build job here, and then switch to the Artifacts tab.

@sinankeskin
Copy link
Author

OK. I've tested and I can confirm this issue has been fixed. Thank you.

trollixx added a commit to trollixx/zeal that referenced this issue Jan 30, 2020
trollixx added a commit to trollixx/zeal that referenced this issue Feb 2, 2020
trollixx added a commit to trollixx/zeal that referenced this issue Feb 7, 2020
trollixx added a commit to trollixx/zeal that referenced this issue Feb 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants